-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: feat: upgrade to angular 19 with small improvements #143
Conversation
Can now be used with standalone components
@pierreavn or @janschab would you like to review the changes? |
Is there anything which needs to be done before it can be merged? Since Angular 19 has been released today, I could also update the repo to Angular 19 |
@the-ult I’d like this to be merged as well, but I don’t have write access. It would be awesome if you could update it to 19 as well. |
Then I will update the PR in the next days |
Thanks so much for this @the-ult! |
Refactor to use signals and linkedSignal
Thank you for upgrading to Angualr 19. I hope the author can merge the PR as soon as possible。@pierreavn @janschab |
@the-ult I feel that the original author may no longer maintain the library, as it has been inactive for 8 months. Suggest the expert fork a new library and publish it on npm. We are all using the new library of experts. |
I'm gonna add some tests first (next few days.. gotta find/make some time) I think before forking this, might be better to help this official PR another time: |
Thank you. Looking forward to official support! This way, we won't be afraid of relying on outdated packages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me, I've just saw 2 comments with suggestions.
When you apply them, I'll merge your PR.
Again, thank you a lot for your great work.
After that, I'll do another MR to upgrade Tabler icons to v3.22.0
I've directly merged your PR and made the requested changes. |
Thanks a lot @pierreavn 👍 Will try and add the tests in an additional PR |
Upgrade the repo to Angular 19 and improve some code according to new standards
v18v19probably as separate issue:
upgrade tabler/icons to v3.x ??fixes #141