Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: feat: upgrade to angular 19 with small improvements #143

Merged
merged 22 commits into from
Nov 25, 2024

Conversation

the-ult
Copy link

@the-ult the-ult commented Nov 5, 2024

Upgrade the repo to Angular 19 and improve some code according to new standards

  • Upgrade angular to v18 v19
  • upgrade dependencies
  • replace TSlint with ESLint
    • This is just the simple migration, no extra ESLint plugins or strictness added -> should be separate PR
  • Improve/adjust docs
  • Migrate to signals
  • Add tests

probably as separate issue:

  • upgrade tabler/icons to v3.x ??

fixes #141

@the-ult the-ult changed the title WIP: feat: upgrade to angular 18 with small improvements feat: upgrade to angular 18 with small improvements Nov 6, 2024
@the-ult
Copy link
Author

the-ult commented Nov 6, 2024

@pierreavn or @janschab would you like to review the changes?

@the-ult
Copy link
Author

the-ult commented Nov 19, 2024

@janschab

Is there anything which needs to be done before it can be merged?

Since Angular 19 has been released today, I could also update the repo to Angular 19

@janschab
Copy link
Contributor

@the-ult I’d like this to be merged as well, but I don’t have write access. It would be awesome if you could update it to 19 as well.

@the-ult
Copy link
Author

the-ult commented Nov 20, 2024

Then I will update the PR in the next days

@apollisa
Copy link

Thanks so much for this @the-ult!

@the-ult the-ult changed the title feat: upgrade to angular 18 with small improvements WIP: feat: upgrade to angular 19 with small improvements Nov 22, 2024
@xylplm
Copy link

xylplm commented Nov 23, 2024

Thank you for upgrading to Angualr 19. I hope the author can merge the PR as soon as possible。@pierreavn @janschab

@xylplm
Copy link

xylplm commented Nov 23, 2024

@the-ult I feel that the original author may no longer maintain the library, as it has been inactive for 8 months. Suggest the expert fork a new library and publish it on npm. We are all using the new library of experts.

@the-ult
Copy link
Author

the-ult commented Nov 24, 2024

I'm gonna add some tests first (next few days.. gotta find/make some time)

I think before forking this, might be better to help this official PR another time:

@xylplm
Copy link

xylplm commented Nov 25, 2024

I'm gonna add some tests first (next few days.. gotta find/make some time)

I think before forking this, might be better to help this official PR another time:

Thank you. Looking forward to official support! This way, we won't be afraid of relying on outdated packages

@pierreavn
Copy link
Owner

Hi @the-ult and @xylplm, first of all thank you for the work.
I had a long off time due to a lot of things, but I'm back and ready to review your code :)
I keep you in touch very soon, just the time to review code.

Copy link
Owner

@pierreavn pierreavn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me, I've just saw 2 comments with suggestions.
When you apply them, I'll merge your PR.
Again, thank you a lot for your great work.

After that, I'll do another MR to upgrade Tabler icons to v3.22.0

README.md Show resolved Hide resolved
package.json Show resolved Hide resolved
@pierreavn pierreavn merged commit 38d3db5 into pierreavn:master Nov 25, 2024
@pierreavn
Copy link
Owner

pierreavn commented Nov 25, 2024

I've directly merged your PR and made the requested changes.
Everything is on master: Angular 18 & 19 support and latest Tabler Icons version 3.22.0 🎊 (just mentioned your contribution in the README).
Can you check everything is working on your side @the-ult @xylplm before I publish the package to npm?

@the-ult
Copy link
Author

the-ult commented Nov 25, 2024

Thanks a lot @pierreavn 👍

Will try and add the tests in an additional PR

@the-ult the-ult deleted the feature/upgrade-repo branch November 26, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to support angular 18
5 participants