Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies #152

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

the-ult
Copy link

@the-ult the-ult commented Dec 21, 2024

  • Update dependencies
  • Remove unused test packages
  • Remove karma (since there are no tests)
  • Refactor eslint to use ES modules
  • Set compatibility to Angular 19

N.B.

  • Should be tested, to make sure using "moduleResolution": "bundler", does not break anything

The Ult added 4 commits December 21, 2024 15:56
There are no test files (yet) and karma is preventing the use of ES modules

N.B.
We should add (Vitest) tests in the future
@pierreavn
Copy link
Owner

pierreavn commented Dec 21, 2024

All changes looks good to me, I'll test everything in the following days. Thank you a lot!

My philosophy since the beginning of the project has been to follow the tabler icons versions, I think it's easier for users to understand that Tabler icons v3.26 will be available with [email protected]. It's the reason why I've not created a v4 :)

@the-ult
Copy link
Author

the-ult commented Dec 22, 2024

My philosophy since the beginning of the project has been to follow the tabler icons versions, I think it's easier for users to understand that Tabler icons v3.26 will be available with [email protected]. It's the reason why I've not created a v4 :)

I added a section about the versioning in the README PR:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants