Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pycopancore reduced to core #192

Draft
wants to merge 110 commits into
base: master
Choose a base branch
from
Draft

Conversation

jnnsbrr
Copy link
Collaborator

@jnnsbrr jnnsbrr commented Jul 2, 2024

This PR includes 2 major parts:

General changes to pycopancore

  • replaced relative imports with absolute ones for better overview (https://peps.python.org/pep-0008/#imports)
  • includes some commits also of @mensch72 that did not make it into the master but in the the fork and couple_lpjml branch
  • debugging of both previous bullet points
  • model_logic was made more flexible for missing processes, process_taxa
  • I did not change the functionality of copan:CORE, just made it more flexible for alternative usages

pycopancore split into additional repositories ...

pycopan_more

  • all components that are not the core (base, etc.)
  • all models
  • all studies

pycopanlpjml new

  • lpjml component
  • relies on pycoupler and pycopancore
  • simplified syntax, structure compared to pycopancore

inseeds new

  • inseeds components (farmer_management, base)
  • models (farmer_management)
  • simplified syntax, structure compared to pycopancore

mensch72 and others added 30 commits November 18, 2021 21:14
@jnnsbrr jnnsbrr added enhancement lpjml stuff concerning the coupling to LPJmL labels Jul 2, 2024
@jnnsbrr jnnsbrr requested a review from zugnachpankow July 4, 2024 13:37
@jnnsbrr jnnsbrr changed the title InSEEDS (coupled copan:CORE LPJmL) pycopancore reduced to core Nov 28, 2024
@jnnsbrr
Copy link
Collaborator Author

jnnsbrr commented Nov 28, 2024

@mensch72, @zugnachpankow and @hannah-pra can you please review the code within the next weeks? This should be merged soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement lpjml stuff concerning the coupling to LPJmL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants