Review Linting #224
Merged
Review Linting #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- and disable single one locally
- remove unused variables - correct `no-member` where straightforward, keep disable for later review of remaining cases
- as `degrees` argument was overridden by `self.degree`, but should use `self.indegree` or `self.outdegree` respectively - renamed `degrees` -> `degree` - went unnoticed because SmallTestNetwork is undirected and pylint flag `unused-argument` was globally disabled
- and a remaining case of `unused-variable` - rename `degrees` -> `degree`
- `unsubscriptable object`: useless suppression - `arguments-out-of-order`: false positive, disabled locally - `keyword-arg-before-vararg`: disabled locally, as respective methods follow the igraph methods they are wrapping. (doesn't mean igraph syntax isn't problematic though)
This was
linked to
issues
May 21, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #224 +/- ##
==========================================
+ Coverage 66.94% 68.63% +1.68%
==========================================
Files 44 44
Lines 6151 6138 -13
==========================================
+ Hits 4118 4213 +95
+ Misses 2033 1925 -108 ☔ View full report in Codecov by Sentry. |
- `GrowPreferentially_old()`, `GrowPreferentially()` and `GrowWeights()` - minor linting in `GrowPreferentially_old()`
- to conform with `scipy>=1.14`, namely substitute deprecated shorthand `*_matrix.A` with `*_matrix.toarray()`
- skip `test_GrowPreferentially_old()`, because it will curiously cause builds to time out.
- skip `test_GrowPreferentially()` with `nsi=False`, as it will erraneously run into and endless while loop causing builds to time out. - add FIXMEs at potentially endless while loops - reduce n_nodes on remaining `Grow*` tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the idea is to drop global disables of Pylint flags in
pyproject.tomlwhere possible.This PR contains the most straightforward cases, but more work needs to be done. I would argue to keep
for now.
Thus,
"arguments-differ", "no-member"and"no-name-in-module"are yet to be re-enabled and respective cases fixed (see e.g. #222 concerning"no-member").