MAINT: extend caching and review Surrogates API
#236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend caching according to 93ab748 to - `RecurrenceNetwork` and child classes - `Surrogates` Review API of `Surrogates` to enable caching and reduce redundancy - remove unhashable argument `original_data` in surrogate methods, use respective attribute - make embedding a property as in `RecurrencePlot` - substitute static method `normalize_time_series_array()` with regular method `normalize_original_data()` with same functionality - add attributes `self.N`, `self.n_time` - adapt tests, implement additional tests Resolve and re-enable pylint flag `no-member`
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #236 +/- ##
==========================================
+ Coverage 68.71% 70.03% +1.31%
==========================================
Files 44 44
Lines 6138 6124 -14
==========================================
+ Hits 4218 4289 +71
+ Misses 1920 1835 -85 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit message
Extend caching according to 93ab748 to
RecurrenceNetworkand child classesSurrogatesReview API of
Surrogatesto enable caching and reduce redundancyoriginal_datain surrogate methods, use respective attributeembeddinga property as inRecurrencePlotnormalize_time_series_array()with regular methodnormalize_original_data()with same functionalityrecurrence_plot()a static method (missing in commit message)self.N,self.n_timeResolve and re-enable pylint flag
no-memberComment
The changed API of the
Surrogatesclass should be reviewed. Also, what isSurrogates.recurrence_plot()intended for when we have theRecurrencePlotclass?