Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust ECEMF mapping #443

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Conversation

robertpietzcker
Copy link
Contributor

Purpose of this PR

update ECEMF mappings and tutorial on Excel use

Checklist:

  • I checked that using Excel had no side-effects occur (changed values, many new quotation marks, …)

robertpietzcker and others added 2 commits February 4, 2025 16:48
more precise info about using Excel
@robertpietzcker
Copy link
Contributor Author

robertpietzcker commented Feb 4, 2025

@fbenke-pik I have no idea why the WHOLE files checkUnitFactor.R and renameOldVariables.R are shown as changed when I don't tick "hide whitespace"?

I can't remember changing anything in renameOldVariables, and in checkUnitFactor I didn't do anything except change one line in this file in RStudio

@orichters
Copy link
Contributor

@fbenke-pik I have no idea why the WHOLE files checkUnitFactor.R and renameOldVariables.R are shown as changed when I don't tick "hide whitespace"?

I can't remember changing anything in renameOldVariables, and in checkUnitFactor I didn't do anything except change one line in this file in RStudio

That is probably just the line endings that have changed. Can you please add a file .gitattributes that just contains the following:

* text eol=lf

I hope this might fix it.

@robertpietzcker
Copy link
Contributor Author

I already have such a file with exactly that content in my folder?

@orichters
Copy link
Contributor

orichters commented Feb 4, 2025

I already have such a file with exactly that content in my folder?

🙈 I forgot that I already added it. Then this is fine, it just harmonizes all files to the same line endings and in this case it adapts them.

@robertpietzcker robertpietzcker merged commit 67b55ba into pik-piam:master Feb 5, 2025
1 check passed
@robertpietzcker robertpietzcker deleted the adjustECEMF branch February 5, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants