-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert const West to East const format #1288
Conversation
if approved, this could also be added to git hooks - perhaps clang-format supports this already ... |
from clang-format-14 onwards |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
closing because it would be easier to add a clang-format and let nature take its course y reformatting files each time they are changed/committed |
reopening with clang format change instead of script |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thank you!
Can you change the signature for pika::start
in the docs to match east-const: https://github.com/pika-org/pika/blob/main/docs/api.rst#pikainithpp? The documentation build is failing because the docs signature doesn't the updated signature in the code anymore.
Update clang-format configuration to enforce rules.