Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert const West to East const format #1288

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Conversation

biddisco
Copy link
Contributor

@biddisco biddisco commented Oct 24, 2024

Update clang-format configuration to enforce rules.

@biddisco
Copy link
Contributor Author

if approved, this could also be added to git hooks - perhaps clang-format supports this already ...

@biddisco
Copy link
Contributor Author

if approved, this could also be added to git hooks - perhaps clang-format supports this already ...

from clang-format-14 onwards
QualifierAlignment: Right

Copy link

codacy-production bot commented Oct 24, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.05% (target: -1.00%) 79.64% (target: 90.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (b163dbe) 18289 13799 75.45%
Head commit (5bba3b1) 18289 (+0) 13790 (-9) 75.40% (-0.05%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1288) 221 176 79.64%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@biddisco
Copy link
Contributor Author

closing because it would be easier to add a clang-format and let nature take its course y reformatting files each time they are changed/committed

@biddisco biddisco closed this Oct 24, 2024
@biddisco
Copy link
Contributor Author

reopening with clang format change instead of script

Copy link
Contributor

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you!

Can you change the signature for pika::start in the docs to match east-const: https://github.com/pika-org/pika/blob/main/docs/api.rst#pikainithpp? The documentation build is failing because the docs signature doesn't the updated signature in the code anymore.

@msimberg msimberg added this pull request to the merge queue Oct 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 24, 2024
@msimberg msimberg merged commit 8cca430 into pika-org:main Oct 25, 2024
35 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants