Make req.route an object saving route and baseUrl #37
+21
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using an error handler you have access to req.route which describes the most recently matched route. However, some other informaiton (like req.baseUrl) gets changed before the error handler runs. This commit changes req.route to an object that also contains the req.baseUrl before it gets changed. Since the actual route object is not scoped to the current event, this commit instead uses a new object to store the baseUrl but sets the __proto__ to the route object so that all its properties are also available.
|
Some thoughts/questions:
|
| @@ -271,7 +271,8 @@ Router.prototype.handle = function handle(req, res, callback) { | |||
|
|
|||
| // store route for dispatch on change | |||
| if (route) { | |||
| req.route = route | |||
| req.route = req.route || { __proto__: route } | |||
| req.route.baseUrl = req.baseUrl; | |||
There was a problem hiding this comment.
Oops, must remove the habitual ;
|
Any thoughts/feedback on this? |
dougwilson
force-pushed
the
master
branch
2 times, most recently
from
7e90c9e to
8643ec6
Compare
|
Hey! I am (finally) getting around to trying to wrangle these and I think that this is a good idea. Sadly I think it is breaking and since it is so old I am not sure it is a good idea to revive this as is or take a new try specifically on top of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to implement expressjs/express#2883.
When using an error handler you have access to
req.routewhich describes the most recently matched route. However, some other informaiton (likereq.baseUrl) gets changed before the error handler runs.This commit changes
req.routeto an object that also contains thereq.baseUrlbefore it gets changed.Since the actual
routeobject is not scoped to the current event, this commit instead uses a new object to store thebaseUrlbut sets the__proto__to therouteobject so that all its properties are also available.