Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart method to yahoo-finance #66

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

reed-lawrence
Copy link

Basic functionality of the chart method within yahoo finance. Stylistically incomplete and needs polish, potential options parameters to modify the URL request.

Just wanted to contribute the basic functionality to perhaps expand upon.

@gadicc
Copy link
Collaborator

gadicc commented Jan 25, 2020

Thanks, @reed-lawrence, this is a welcome start!

One thing I did notice, is if you could please add:

var Promise = require('bluebird');

just to maintain consistency with the rest of the project (for the current major version, at least).

And maybe also some very rough docs :) Even if it just shows an example call with the example data returned?

@pilwon, not sure if you have any further thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants