Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data Selector for JSON Payload #437

Open
wants to merge 12 commits into
base: 1.x
Choose a base branch
from
Open

Data Selector for JSON Payload #437

wants to merge 12 commits into from

Conversation

cancan101
Copy link
Contributor

@cancan101 cancan101 commented Nov 22, 2024 •
edited
Loading

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@cancan101 cancan101 mentioned this pull request Feb 14, 2025
Open
@cancan101
Copy link
Contributor Author

@fashxp I addressed the comments.

fashxp
fashxp requested changes Feb 21, 2025
View reviewed changes
Copy link
Member

@fashxp fashxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, one minor adaption we need.

src/DataSource/Interpreter/JsonFileInterpreter.php Outdated
//nothing to do
$path = $settings['path'];
try {
(new Parser)->parse($path);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should allow empty paths here as well...

@fashxp fashxp added this to the 1.11.0 milestone Feb 21, 2025
@cancan101 cancan101 requested a review from fashxp February 21, 2025 15:59
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fashxp fashxp Awaiting requested review from fashxp

Assignees

@fashxp fashxp

Labels
Improvement Pimcore:ToDo
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@cancan101 @fashxp @wisconaut