-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RabbitMQ as recommended system-requirement #16885
Add RabbitMQ as recommended system-requirement #16885
Conversation
Review Checklist
|
LGTM, I think we should also include an example of how to configure RabbitMQ, that would make it more convenient for users 😊 |
I would use this scheme as an example: This way there is an .ENV varaible for the base DSN and it is possible to use multiple queues. Alternatively, I can document it in a simplified way so that the .ENV contains the queue directly and therefore all tasks run into it (I find it not recommend but possibly easier and more error-free to understand for the usual user). |
For me it would be fine that we just reference to the skeleton file. |
Btw. just released v3.2 of our docker image with AMQP support ... just building at the moment: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we also make that statement consistent: https://github.com/pimcore/pimcore/blob/11.x/doc/01_Getting_Started/02_Advanced_Installation_Topics/01_Symfony_Messenger.md?plain=1#L22
For |
@skoch98 yes, I'd leave failed queue in db as well 👍 |
I updated the docs but please make sure that pimcore/skeleton#187 will merged first so that the link is valid :-) Edit: I think this is better for everyone: 4803044 |
doc/01_Getting_Started/02_Advanced_Installation_Topics/01_Symfony_Messenger.md
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
Since pimcore/docker#152 was merged, the image was released and the pr looks good, I merged it. |
As discussed with Bernhard Rusch at the Inspire, I am now adding RabbitMQ as a recommended system requirement in the documentation. I tried to present RabbitMQ's arguments as convincingly as possible... 😄