Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table data object data type #826

Merged
merged 40 commits into from
Jan 16, 2025
Merged

Table data object data type #826

merged 40 commits into from
Jan 16, 2025

Conversation

markus-moser
Copy link
Contributor

@markus-moser markus-moser commented Dec 11, 2024 •
edited
Loading

  • Grid component new features
    • Add option to highlight and remember the active cell
    • Add a mechanism to handle autoWidth columns without autoWidth table
  • Introduce error boundary on data object attribute level
  • Add table data object type
  • Scrollbar for wide tables still missing, will be added as soon as general concept for it is implemented

markus-moser and others added 28 commits December 11, 2024 19:32
@markus-moser
Table data object data type
b370f58
@markus-moser @github-actions
Apply eslint-fixer changes
95d261e
@markus-moser @github-actions
Automatic frontend build
067bf1d
@markus-moser
Grid active cell logic and implement basic table functions
468812e
@markus-moser
Fixed rows/columns and not editable mode
682b00d
@markus-moser
Merge remote-tracking branch 'origin/1.x' into table-type
e20c5c3 
# Conflicts:
#	assets/js/src/core/components/modal/form-modal/hooks/use-form-modal.tsx
#	public/build/00f5a0a4-7572-4faa-8f25-b6fec814dbdb/105.js
#	public/build/00f5a0a4-7572-4faa-8f25-b6fec814dbdb/105.js.LICENSE.txt
#	public/build/00f5a0a4-7572-4faa-8f25-b6fec814dbdb/core-dll.css
#	public/build/00f5a0a4-7572-4faa-8f25-b6fec814dbdb/core-dll.js.LICENSE.txt
#	public/build/00f5a0a4-7572-4faa-8f25-b6fec814dbdb/fonts/Lato-Bold.636be8de.ttf
#	public/build/00f5a0a4-7572-4faa-8f25-b6fec814dbdb/fonts/Lato-Light.c7400fca.ttf
#	public/build/00f5a0a4-7572-4faa-8f25-b6fec814dbdb/fonts/Lato-Regular.9d883d54.ttf
#	public/build/00f5a0a4-7572-4faa-8f25-b6fec814dbdb/images/layers-2x.8f2c4d11.png
#	public/build/00f5a0a4-7572-4faa-8f25-b6fec814dbdb/images/layers.416d9136.png
#	public/build/00f5a0a4-7572-4faa-8f25-b6fec814dbdb/images/marker-icon.2b3e1faf.png
#	public/build/00f5a0a4-7572-4faa-8f25-b6fec814dbdb/images/spritesheet-2x.7ea3a6d4.png
#	public/build/00f5a0a4-7572-4faa-8f25-b6fec814dbdb/images/spritesheet.a4e0eb7a.svg
#	public/build/00f5a0a4-7572-4faa-8f25-b6fec814dbdb/images/spritesheet.ef32ea2b.png
#	public/build/00f5a0a4-7572-4faa-8f25-b6fec814dbdb/manifest.json
#	public/build/0fbc6576-0473-4d85-bb26-2586e6469221/105.js
#	public/build/0fbc6576-0473-4d85-bb26-2586e6469221/105.js.LICENSE.txt
#	public/build/0fbc6576-0473-4d85-bb26-2586e6469221/core-dll.css
#	public/build/0fbc6576-0473-4d85-bb26-2586e6469221/core-dll.js.LICENSE.txt
#	public/build/0fbc6576-0473-4d85-bb26-2586e6469221/fonts/Lato-Bold.636be8de.ttf
#	public/build/0fbc6576-0473-4d85-bb26-2586e6469221/fonts/Lato-Light.c7400fca.ttf
#	public/build/0fbc6576-0473-4d85-bb26-2586e6469221/fonts/Lato-Regular.9d883d54.ttf
#	public/build/0fbc6576-0473-4d85-bb26-2586e6469221/images/layers-2x.8f2c4d11.png
#	public/build/0fbc6576-0473-4d85-bb26-2586e6469221/images/layers.416d9136.png
#	public/build/0fbc6576-0473-4d85-bb26-2586e6469221/images/marker-icon.2b3e1faf.png
#	public/build/0fbc6576-0473-4d85-bb26-2586e6469221/images/spritesheet-2x.7ea3a6d4.png
#	public/build/0fbc6576-0473-4d85-bb26-2586e6469221/images/spritesheet.a4e0eb7a.svg
#	public/build/0fbc6576-0473-4d85-bb26-2586e6469221/images/spritesheet.ef32ea2b.png
#	public/build/0fbc6576-0473-4d85-bb26-2586e6469221/manifest.json
#	public/build/23c674cc-9fbd-45a6-a9fd-d5564d0711af/main.js
#	public/build/23c674cc-9fbd-45a6-a9fd-d5564d0711af/main.js.LICENSE.txt
#	public/build/44a60c74-f54d-4227-8d0b-e62db03438e5/main.js
#	public/build/44a60c74-f54d-4227-8d0b-e62db03438e5/main.js.LICENSE.txt
#	public/build/690abc15-c7d9-49ee-8284-d17fa4245933/vendor.js
#	public/build/690abc15-c7d9-49ee-8284-d17fa4245933/vendor.js.LICENSE.txt
#	public/build/8179d1a3-c91f-45f2-8836-37db0f30a89d/vendor.js
#	public/build/8179d1a3-c91f-45f2-8836-37db0f30a89d/vendor.js.LICENSE.txt
#	public/build/b3e766d2-8cf6-49b0-86f0-38699fcf50c6/vendor.js
#	public/build/b3e766d2-8cf6-49b0-86f0-38699fcf50c6/vendor.js.LICENSE.txt
#	public/build/c9660658-898a-46c5-962f-75d736f12f1b/main.js
#	public/build/c9660658-898a-46c5-962f-75d736f12f1b/main.js.LICENSE.txt
#	public/build/de2bed0f-9487-43f2-9fa7-fa8ff064597d/105.js
#	public/build/de2bed0f-9487-43f2-9fa7-fa8ff064597d/105.js.LICENSE.txt
#	public/build/de2bed0f-9487-43f2-9fa7-fa8ff064597d/core-dll.css
#	public/build/de2bed0f-9487-43f2-9fa7-fa8ff064597d/core-dll.js.LICENSE.txt
#	public/build/de2bed0f-9487-43f2-9fa7-fa8ff064597d/fonts/Lato-Bold.636be8de.ttf
#	public/build/de2bed0f-9487-43f2-9fa7-fa8ff064597d/fonts/Lato-Light.c7400fca.ttf
#	public/build/de2bed0f-9487-43f2-9fa7-fa8ff064597d/fonts/Lato-Regular.9d883d54.ttf
#	public/build/de2bed0f-9487-43f2-9fa7-fa8ff064597d/images/layers-2x.8f2c4d11.png
#	public/build/de2bed0f-9487-43f2-9fa7-fa8ff064597d/images/layers.416d9136.png
#	public/build/de2bed0f-9487-43f2-9fa7-fa8ff064597d/images/marker-icon.2b3e1faf.png
#	public/build/de2bed0f-9487-43f2-9fa7-fa8ff064597d/images/spritesheet-2x.7ea3a6d4.png
#	public/build/de2bed0f-9487-43f2-9fa7-fa8ff064597d/images/spritesheet.a4e0eb7a.svg
#	public/build/de2bed0f-9487-43f2-9fa7-fa8ff064597d/images/spritesheet.ef32ea2b.png
#	public/build/de2bed0f-9487-43f2-9fa7-fa8ff064597d/manifest.json
@markus-moser
Fix translation keys
c6800d5
@markus-moser
Remove unused import
f52ba88
@markus-moser @github-actions
Apply eslint-fixer changes
b07e8b4
@markus-moser @github-actions
Automatic frontend build
7aecbca
@markus-moser
Wrap buttons into button group
79455ea
@markus-moser @github-actions
Automatic frontend build
7bcbec0
@markus-moser
Add a mechanism to handle autoWidth columns without autoWidth table
02e6142
@markus-moser
Merge remote-tracking branch 'origin/table-type' into table-type
8fff5ab
@markus-moser @github-actions
Automatic frontend build
90ff952
@markus-moser
Simplify autoWidth column logic and make it more robust
1ed1f5f
@markus-moser
Merge remote-tracking branch 'origin/table-type' into table-type
a979cda
@markus-moser @github-actions
Automatic frontend build
c058973
@markus-moser
Fix handling of empty values without rows/columns definition
2604a36
@markus-moser
Merge remote-tracking branch 'origin/table-type' into table-type
b7d6eb7
@markus-moser @github-actions
Automatic frontend build
8063973
@markus-moser
Introduce error boundary on data object attribute level
c8d4404
@markus-moser
Merge remote-tracking branch 'origin/table-type' into table-type
3187f13
@markus-moser @github-actions
Automatic frontend build
ecdad2d
@markus-moser
Bugfixing
5ddf628
@markus-moser
Merge remote-tracking branch 'origin/table-type' into table-type
2da40a8
@markus-moser
Remove console.log
7187d69
@markus-moser @github-actions
Automatic frontend build
47ea613
@markus-moser
Copy link
Contributor Author

Blocked by #832

@markus-moser
Merge remote-tracking branch 'origin/1.x' into table-type
1b7f895 
# Conflicts:
#	assets/js/src/core/components/grid/grid-cell/grid-row.tsx
#	assets/js/src/core/components/grid/grid.tsx
#	assets/js/src/core/modules/element/dynamic-types/defintinitions/objects/data-related/components/structured-table/structured-table.tsx
#	assets/js/src/core/types/components/types.ts
#	public/build/0fbc6576-0473-4d85-bb26-2586e6469221/105.js
#	public/build/0fbc6576-0473-4d85-bb26-2586e6469221/105.js.LICENSE.txt
#	public/build/0fbc6576-0473-4d85-bb26-2586e6469221/core-dll.css
#	public/build/0fbc6576-0473-4d85-bb26-2586e6469221/core-dll.js.LICENSE.txt
#	public/build/0fbc6576-0473-4d85-bb26-2586e6469221/fonts/Lato-Bold.636be8de.ttf
#	public/build/0fbc6576-0473-4d85-bb26-2586e6469221/fonts/Lato-Light.c7400fca.ttf
#	public/build/0fbc6576-0473-4d85-bb26-2586e6469221/fonts/Lato-Regular.9d883d54.ttf
#	public/build/0fbc6576-0473-4d85-bb26-2586e6469221/images/layers-2x.8f2c4d11.png
#	public/build/0fbc6576-0473-4d85-bb26-2586e6469221/images/layers.416d9136.png
#	public/build/0fbc6576-0473-4d85-bb26-2586e6469221/images/marker-icon.2b3e1faf.png
#	public/build/0fbc6576-0473-4d85-bb26-2586e6469221/images/spritesheet-2x.7ea3a6d4.png
#	public/build/0fbc6576-0473-4d85-bb26-2586e6469221/images/spritesheet.a4e0eb7a.svg
#	public/build/0fbc6576-0473-4d85-bb26-2586e6469221/images/spritesheet.ef32ea2b.png
#	public/build/55f46957-85af-4116-b9d5-b40357f01669/105.js
#	public/build/55f46957-85af-4116-b9d5-b40357f01669/105.js.LICENSE.txt
#	public/build/55f46957-85af-4116-b9d5-b40357f01669/core-dll.css
#	public/build/55f46957-85af-4116-b9d5-b40357f01669/core-dll.js.LICENSE.txt
#	public/build/55f46957-85af-4116-b9d5-b40357f01669/fonts/Lato-Bold.636be8de.ttf
#	public/build/55f46957-85af-4116-b9d5-b40357f01669/fonts/Lato-Light.c7400fca.ttf
#	public/build/55f46957-85af-4116-b9d5-b40357f01669/fonts/Lato-Regular.9d883d54.ttf
#	public/build/55f46957-85af-4116-b9d5-b40357f01669/images/layers-2x.8f2c4d11.png
#	public/build/55f46957-85af-4116-b9d5-b40357f01669/images/layers.416d9136.png
#	public/build/55f46957-85af-4116-b9d5-b40357f01669/images/marker-icon.2b3e1faf.png
#	public/build/55f46957-85af-4116-b9d5-b40357f01669/images/spritesheet-2x.7ea3a6d4.png
#	public/build/55f46957-85af-4116-b9d5-b40357f01669/images/spritesheet.a4e0eb7a.svg
#	public/build/55f46957-85af-4116-b9d5-b40357f01669/images/spritesheet.ef32ea2b.png
#	public/build/690abc15-c7d9-49ee-8284-d17fa4245933/vendor.js
#	public/build/690abc15-c7d9-49ee-8284-d17fa4245933/vendor.js.LICENSE.txt
#	public/build/9723629a-92f8-47be-8e81-a028d123581c/main.js
#	public/build/9723629a-92f8-47be-8e81-a028d123581c/main.js.LICENSE.txt
#	public/build/c6623f2d-e8ea-45aa-acfa-03ee269eaf0f/main.js
#	public/build/c6623f2d-e8ea-45aa-acfa-03ee269eaf0f/main.js.LICENSE.txt
#	public/build/c9660658-898a-46c5-962f-75d736f12f1b/main.js
#	public/build/c9660658-898a-46c5-962f-75d736f12f1b/main.js.LICENSE.txt
#	public/build/e53e802c-f195-4756-ab58-045e9f1d5f09/vendor.js
#	public/build/e53e802c-f195-4756-ab58-045e9f1d5f09/vendor.js.LICENSE.txt
#	public/build/ecec161c-3a68-45f3-86e5-5d97376651bb/vendor.js
#	public/build/ecec161c-3a68-45f3-86e5-5d97376651bb/vendor.js.LICENSE.txt
#	public/build/f29d2627-f6b2-440f-8c21-88b0784ecf42/105.js
#	public/build/f29d2627-f6b2-440f-8c21-88b0784ecf42/105.js.LICENSE.txt
#	public/build/f29d2627-f6b2-440f-8c21-88b0784ecf42/core-dll.css
#	public/build/f29d2627-f6b2-440f-8c21-88b0784ecf42/core-dll.js
#	public/build/f29d2627-f6b2-440f-8c21-88b0784ecf42/core-dll.js.LICENSE.txt
#	public/build/f29d2627-f6b2-440f-8c21-88b0784ecf42/fonts/Lato-Bold.636be8de.ttf
#	public/build/f29d2627-f6b2-440f-8c21-88b0784ecf42/fonts/Lato-Light.c7400fca.ttf
#	public/build/f29d2627-f6b2-440f-8c21-88b0784ecf42/fonts/Lato-Regular.9d883d54.ttf
#	public/build/f29d2627-f6b2-440f-8c21-88b0784ecf42/images/layers-2x.8f2c4d11.png
#	public/build/f29d2627-f6b2-440f-8c21-88b0784ecf42/images/layers.416d9136.png
#	public/build/f29d2627-f6b2-440f-8c21-88b0784ecf42/images/marker-icon.2b3e1faf.png
#	public/build/f29d2627-f6b2-440f-8c21-88b0784ecf42/images/spritesheet-2x.7ea3a6d4.png
#	public/build/f29d2627-f6b2-440f-8c21-88b0784ecf42/images/spritesheet.a4e0eb7a.svg
#	public/build/f29d2627-f6b2-440f-8c21-88b0784ecf42/images/spritesheet.ef32ea2b.png
#	public/build/f29d2627-f6b2-440f-8c21-88b0784ecf42/manifest.json
#	translations/studio.en.yaml
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@markus-moser markus-moser marked this pull request as ready for review January 16, 2025 15:22
@markus-moser markus-moser merged commit 4bed202 into 1.x Jan 16, 2025
1 check passed
@markus-moser markus-moser deleted the table-type branch January 16, 2025 15:31
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@markus-moser