-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #849
base: 1.x
Are you sure you want to change the base?
Update README.md #849
Conversation
Quality Gate passedIssues Measures |
also the other examples don't really work... I get the error:
|
Hi @dpfaffenbauer 👋 thanks for checking out the plugin system. :) |
The onInit-Method in this case should be related to the plugin-system, I guess. |
@vin0401 here is what I did so far: dpfaffenbauer/CoreShop@1f96fac |
@dpfaffenbauer - I was able to figure it out. :) The error you send us is triggered due to this line: You are injecting a react component in this case but it should be the folderTabExtension-Module you created. We renamed the And the widgetManager.openBottomWidget({
name: 'My first widget',
component: 'my-first-widget',
config: {}
}); I will fix those cases in the next days in this PR with your changes included. And maybe some additional information that could be interesting for you:
|
❤️ Nothing more I can say :) Re 2. We would be happy to assist in all sorts possible, I guess we have quite some plugins to migrate and we, together, can learn a lot and enhance a lot. |
Restructure the plugin readme, I find it a bit confusing to find essential information at the end.
Also re the DllReference, please someone can comment on my comment? it does not work for me...