[Bug]: Chrome shouldn't be closed when using Chrome service (#61)

* fix chromium to close page instead of closing browser Co-authored-by: Vincent Robert <[email protected]> * Update Chromium.php * Update Chromium.php * remove empty spaces --------- Co-authored-by: Vincent Robert <[email protected]>
pimcore · Feb 19, 2024 · a86b658 · a86b658
1 parent 4151b8a
commit a86b658
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/Processor/Chromium.php b/src/Processor/Chromium.php
@@ -120,8 +120,8 @@ public function getPdfFromString(string $html, array $params = [], bool $returnF
             ]);
         }
 
+        $page = $browser->createPage();
         try {
-            $page = $browser->createPage();
             $page->setHtml($html, 5000);
 
             $pdf = $page->pdf($params);
@@ -136,7 +136,7 @@ public function getPdfFromString(string $html, array $params = [], bool $returnF
             Logger::debug('Could not create pdf with chromium: '. print_r($e, true));
             $output = (string) $e;
         } finally {
-            $browser->close();
+            $page->close();
         }
 
         return $output;