Merge pull request #331 from pimlicolabs/add-second-simulation-logs

Add logs to check if the second simulation fails
pimlicolabs · Oct 18, 2024 · f7ccd43 · f7ccd43
2 parents e312a2d + dda919c
commit f7ccd43
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/src/rpc/rpcHandler.ts b/src/rpc/rpcHandler.ts
@@ -468,7 +468,7 @@ export class RpcHandler implements IRpcEndpoint {
             entryPoint,
             queuedUserOperations,
             true,
-            stateOverrides
+            deepHexlify({ ...stateOverrides })
         )
 
         let { verificationGasLimit, callGasLimit } =
@@ -527,9 +527,8 @@ export class RpcHandler implements IRpcEndpoint {
             callGasLimit = 0n
         }
 
-        // If a balance override is provided for the sender, perform an additional simulation
-        // to verify the userOperation succeeds with the specified balance.
-        if (stateOverrides?.[userOperation.sender]?.balance) {
+        // Run second time without state overrides
+        try {
             await this.validator.getExecutionResult(
                 {
                     ...userOperation,
@@ -542,8 +541,10 @@ export class RpcHandler implements IRpcEndpoint {
                 entryPoint,
                 queuedUserOperations,
                 false,
-                deepHexlify(stateOverrides)
+                deepHexlify({ ...stateOverrides })
             )
+        } catch (err) {
+            this.logger.error(err, "Second simulations fail")
         }
 
         if (isVersion07(userOperation)) {