Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ikhal: Deleting multiple instances of the same recurring event raises khal.khalendar.exceptions.EtagMissmatch #1190

Closed
lmoellendorf opened this issue Sep 27, 2022 · 2 comments · Fixed by #1273

Comments

@lmoellendorf
Copy link

lmoellendorf commented Sep 27, 2022

I was experiencing the same issue as explained in #793. I saw this should have been fixed by https://github.com/pimutils/khal/pull/1158/commits

So I updated my khal instance from github:

pip install --user git+https://github.com/pimutils/khal
...
Successfully installed khal-0.10.6.dev104+gb824798

In my calendar there is a recurring event from which I want to delete [EDIT: two consecutive multiple] instances. If I do this in ikhal and close I ikhal, only the first instance is deleted and an exception is raised:

Traceback (most recent call last):
  File "/home/lars/.local/lib/python3.10/site-packages/khal/ui/__init__.py", line 1364, in start_pane
    loop.run()
  File "/home/lars/.local/lib/python3.10/site-packages/urwid/main_loop.py", line 287, in run
    self._run()
  File "/home/lars/.local/lib/python3.10/site-packages/urwid/main_loop.py", line 385, in _run
    self.event_loop.run()
  File "/home/lars/.local/lib/python3.10/site-packages/urwid/main_loop.py", line 790, in run
    self._loop()
  File "/home/lars/.local/lib/python3.10/site-packages/urwid/main_loop.py", line 827, in _loop
    self._watch_files[fd]()
  File "/home/lars/.local/lib/python3.10/site-packages/urwid/raw_display.py", line 416, in <lambda>
    wrapper = lambda: self.parse_input(
  File "/home/lars/.local/lib/python3.10/site-packages/urwid/raw_display.py", line 515, in parse_input
    callback(processed, processed_codes)
  File "/home/lars/.local/lib/python3.10/site-packages/urwid/main_loop.py", line 412, in _update
    self.process_input(keys)
  File "/home/lars/.local/lib/python3.10/site-packages/urwid/main_loop.py", line 519, in process_input
    something_handled |= bool(self.unhandled_input(k))
  File "/home/lars/.local/lib/python3.10/site-packages/urwid/main_loop.py", line 565, in unhandled_input
    return self._unhandled_input(input)
  File "/home/lars/.local/lib/python3.10/site-packages/khal/ui/base.py", line 205, in on_key_press
    self.backtrack()
  File "/home/lars/.local/lib/python3.10/site-packages/khal/ui/base.py", line 190, in backtrack
    cb(data)
  File "/home/lars/.local/lib/python3.10/site-packages/khal/ui/__init__.py", line 1118, in cleanup
    self.collection.delete_instance(href, etag, account, rec_id)
  File "/home/lars/.local/lib/python3.10/site-packages/khal/khalendar/khalendar.py", line 243, in delete_instance
    raise EtagMissmatch()
khal.khalendar.exceptions.EtagMissmatch

EDIT: Deleting only one instance of a recurring event works as expected. It does not matter if I delete two or three events and the events do not have to be consecutive

@lmoellendorf lmoellendorf changed the title ikhal: Deleting two consecutive instances of the same recurring event raises khal.khalendar.exceptions.EtagMissmatch ikhal: Deleting multiple instances of the same recurring event raises khal.khalendar.exceptions.EtagMissmatch Sep 27, 2022
@WhyNotHugo
Copy link
Member

Maybe fixed by #1198

@geier
Copy link
Member

geier commented Jun 16, 2023

if you can, please test #1273

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants