ikhal: fix deleting of multiple instances #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 16, 2023
WhyNotHugo
approved these changes
Jun 17, 2023
|
thanks for reviewing @WhyNotHugo! I'll wait a few more days and see if someone is able to give this a try. |
|
I tested it. It works without problem. Thanks for having it fixed. |
This sounds unrelated. Doesn't it also print the same thing when deleting a non-recurring event? |
When deleting multiple instances of the same recurring event, ikhal would crash because of mismatching etags. This would happen, because we delete one instance after the next, each time updating the etag. As we check for matching etags when deleting (the one in the database and the one stored in ikhal), this would crash ikhal. Matching the etag makes sense, as we might overwrite freshly synced data otherwise. For now, the server wins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deleting multiple instances of the same recurring event, ikhal would crash because of mismatching etags. This would happen, because we delete one instance after the next, each time updating the etag. As we check for matching etags when deleting (the one in the database and the one stored in ikhal), this would crash ikhal. Matching the etag makes sense, as we might overwrite freshly synced data otherwise. For now, the server wins.
fix #1190