Do not evaluate etag when deleting instances #1198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If multiple instances of an event are deleted one after the other, the event will be updated each time and thus its etag will change dynamically each time. This will lead to a mismatch with the static etag recorded at the time when the instances are queued for deletion. Instead of re-adjusting the deletion queue each time, do not compare the dynamic etag with the static etag. The etag for the event will be updated anyway.
tobiolo
force-pushed
the
delete-multiple-instances
branch
from
356b987
to
6a91d63
Compare
|
Thank you for sending this PR, and sorry for not having a look until now. I believe removing those etag checks is a mistake, or at least we should then decide that editing events in khal always wins and overwrites whatever currently is on disk. I have instead created #1273, which checks etags for subsequent deletions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If multiple instances of an event are deleted one after the other, the event will be updated each time and thus its etag will change dynamically each time. This will lead to a mismatch with the static etag recorded at the time when the instances are queued for deletion.
Instead of re-adjusting the deletion queue each time, do not compare the dynamic etag with the static etag. The etag for the event will be updated anyway.