Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not evaluate etag when deleting instances #1198

Closed
wants to merge 1 commit into from
Closed

Do not evaluate etag when deleting instances #1198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions khal/khalendar/khalendar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,9 +242,6 @@ def delete_instance(self,
if self._calendars[calendar]['readonly']:
raise ReadOnlyCalendarError()
event = self.get_event(href, calendar)
if etag and etag != event.etag:
raise EtagMissmatch()

event.delete_instance(rec_id)
self.update(event)
return event
Expand Down
3 changes: 0 additions & 3 deletions khal/khalendar/vdir.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,9 +243,6 @@ def update(self, href: str, item: SupportsRaw, etag: str) -> str:
fpath = self._get_filepath(href)
if not os.path.exists(fpath):
raise NotFoundError(item.uid)
actual_etag = get_etag_from_file(fpath)
if etag != actual_etag:
raise WrongEtagError(etag, actual_etag)

if not isinstance(item.raw, str):
raise TypeError('item.raw must be a unicode string.')
Expand Down