Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for color theme plugins #1303

Closed
wants to merge 2 commits into from
Closed

support for color theme plugins #1303

wants to merge 2 commits into from

Conversation

geier
Copy link
Member

@geier geier commented Oct 26, 2023

With this PR we support plugins that provide color themes.

A first example plugin implementing a gruvbox plugin can be found here: here https://github.com/geier/khal_gruvbox
image

Base automatically changed from config_based_theming to master October 26, 2023 22:02
@geier geier mentioned this pull request Oct 29, 2023
@geier geier marked this pull request as draft November 1, 2023 15:12
@geier geier closed this Apr 14, 2024
@mb720
Copy link

mb720 commented Apr 29, 2024

Since this is closed now, is there another issue that people interested in color theme support can track?

@geier
Copy link
Member Author

geier commented Apr 29, 2024

Not really, with #1312 color theme plugins should work.

Are you looking for something specific?

@mb720
Copy link

mb720 commented Apr 29, 2024

I'm really interested in configuring colors via a different config file than /usr/lib/python3.12/site-packages/khal/ui/colors.py since that gets overwritten on updates (I'm on Arch). I'm currently using khal version 0.11.3 and tried yesterday to get the new color theme plugin to work:

  1. I copied __init__.py to ~/.local/share/khal/plugins, that's my XDG_DATA_HOME.
  2. I changed ~/.config/khal/config to use it:
[view]
  theme = gruvbox
  1. But I got this error:
critical: config error:
critical: in [view] theme: the value "gruvbox" is unacceptable.

Maybe I overlooked something or my version of khal on Arch doesn't support the plugins yet.

Thanks for your help and generally your work on khal!

@geier
Copy link
Member Author

geier commented Apr 29, 2024

Sorry, I forgot to merge the importlib branch (I have done that now).

You will need to install that package, the README has a pointer. Open an issues here or at khal_gruvbox if you have any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants