Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: add the ability to nest teams #38

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

jacobwegner
Copy link
Contributor

@jacobwegner jacobwegner commented Mar 1, 2016

Adds the ability to nest Teams.

Remaining:

  • Standardize convenience methods for ancestors and descendants.
  • Document new templates and add to the appropriate starter project.

For further discussion:

  • Should nesting be supported / the parent relation applied to SimpleTeam as well as Team? (see Split Team model functionality to abstract and concrete classes #25)
  • Is there a better way to handle slug creation on child teams?
  • Are there more performant ways to resolve get_root_team and ancestors using the ORM?
  • Do we allow for "implicit" memberships of teams beneath a parent (see Team.for_user).
  • Related to above, do we enforce a single membership for a user across a Team and its descendants/ancestors?

Comments/Gripes

  • Slug building off of parent pks (versus parent slugs)
    • Why not use the slugs (database limitations)
  • Prevent a team from being an ancestor
  • Team methods should reference self

@jacobwegner
Copy link
Contributor Author

cc: @jtauber and @gregnewman

@jacobwegner
Copy link
Contributor Author

cf #2

@coveralls
Copy link

coveralls commented Sep 11, 2017

Coverage Status

Coverage decreased (-1.5%) to 48.429% when pulling f25b1e4 on jacobwegner:add-nested-teams into 96a72ec on pinax:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants