Updated dependencies #807
Updated dependencies #807
Conversation
…tring_extension.dart that came after the update. Also fixed some test in entity_processor_test.dart
…eature/running_test_fix
|
Could you commit an empty commit to re-trigger the checks? |
Should make #807 work, the pipeline reports failures related to using a Dart version that's incompatible
Update ci.yml
…o test_utils and expect the test to throw this exception
# Conflicts: # .github/workflows/ci.yml # floor/pubspec.lock # floor/pubspec.yaml # floor_generator/pubspec.lock # floor_generator/pubspec.yaml
All test in floor_generator run now
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #807 +/- ##
========================================
Coverage 91.92% 91.92%
========================================
Files 11 11
Lines 223 223
========================================
Hits 205 205
Misses 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
I'm not very experienced with the code base, but for what I can tell it looks good to me with just one question in the comments.
If you don't have any urgency you might want to get a second opinion from @stephanmantel next week.
| @@ -1,6 +1,7 @@ | |||
| import 'dart:io'; | |||
|
|
|||
| import 'package:path/path.dart'; | |||
| // ignore: unnecessary_import | |||
| import 'package:sqflite/sqflite.dart'; | |||
There was a problem hiding this comment.
If it's unnecessary, can it not just be removed?
There was a problem hiding this comment.
The import is necessary. I added the ignore because when we run the build_runner, it indicates that it's an unnecessary import, causing the pipeline to fail.
Updated the dependencies version to the latest version.