Skip to content

Commit

Permalink
[Fix] Add missing dateutil dep (#391)
Browse files Browse the repository at this point in the history
## Problem

SDK version 5.3.0 was accidentally shipped with a missing dependency.
This wasn't caught in testing because the dependency was present in our
`poetry.lock`, which is used when installing in CI, but not in
`pyproject.toml` so it wasn't included for the published package. We got
into this state because we used to have a dependency on
`python-dateutil` which was removed and later re-added when date parsing
was needed for support of import endpoints (added 5.3.0).

Additional manual testing in google colab didn't catch this either
because that environment loads `python-dateutil` as part of the default
environment. 🤦‍♀️

## Solution

Add missing dependency.

## Type of Change

- [x] Bug fix (non-breaking change which fixes an issue)
  • Loading branch information
jhamon authored Sep 19, 2024
1 parent 9892030 commit c85ca40
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
4 changes: 2 additions & 2 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ protobuf = { version = "^4.25", optional = true }
protoc-gen-openapiv2 = {version = "^0.0.1", optional = true }
pinecone-plugin-interface = "^0.0.7"
pinecone-plugin-inference = "^1.1.0"
python-dateutil = ">=2.5.3"

[tool.poetry.group.types]
optional = true
Expand Down

0 comments on commit c85ca40

Please sign in to comment.