Spruce release workflows #216
Conversation
…date makefile to support uploading spruce to test pypi
| @@ -6,10 +6,10 @@ function bumpVersion(currentVersion, bumpType, prerelease) { | |||
| if (prerelease) { | |||
| newVersion = `${newVersion}.${prerelease}`; | |||
| } | |||
| core.setOutput('previous_version', currentVersion) | |||
| core.setOutput('previous_version_tag', `v${currentVersion}`) | |||
| core.setOutput('previous_version', currentVersion); | |||
There was a problem hiding this comment.
Made changes in here initially and backed them out, but prettier had some updates.
| @@ -23,6 +23,11 @@ package: | |||
|
|
|||
| upload: | |||
| poetry publish --verbose --username ${PYPI_USERNAME} --password ${PYPI_PASSWORD} | |||
|
|
|||
| upload-spruce: | |||
There was a problem hiding this comment.
poetry requires a configuration command to set up the repository for test-pypi: https://python-poetry.org/docs/repositories/#publishable-repositories
| testing: | ||
| uses: './.github/workflows/testing.yaml' | ||
|
|
||
| version-and-release-spruce: |
There was a problem hiding this comment.
Initially I wanted to leverage publish-to-pypi which the regular release workflow calls: https://github.com/pinecone-io/pinecone-python-client/blob/main/.github/workflows/publish-to-pypi.yaml
However, since we're not actually bumping the version for Spruce, it felt odd to make a lot of changes to support that. Instead I opted to use the same flow for publishing that we leverage in nightly-release.
Problem
We need a way to ship builds of the
sprucebranch.Solution
Modify existing workflows for
nightly-releaseandreleasefor shipping artifacts to Test PyPI.Workflows update
pyproject.tomlnamefield:pinecone-client-spruce-devandpinecone-client-spruce:pinecone-client-sprucereleases are for use in 3rd party testingpinecone-client-spruce-devreleases are for use in internal testingType of Change
Test Plan
Trigger and validate workflows either locally or from the repo directly.