Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

*: update go mod #174

Merged
merged 5 commits into from
Jun 14, 2019
Merged

*: update go mod #174

merged 5 commits into from
Jun 14, 2019

Conversation

csuzhangxc
Copy link
Member

@csuzhangxc csuzhangxc commented Jun 14, 2019

What problem does this PR solve?

update TiDB parser in go.mod to support more DDL statements.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

@csuzhangxc csuzhangxc added priority/normal Minor change, requires approval from ≥1 primary reviewer status/WIP This PR is still work in progress type/enhancement Performance improvement or refactoring labels Jun 14, 2019
@csuzhangxc
Copy link
Member Author

/run-all-tests

@codecov
Copy link

codecov bot commented Jun 14, 2019

Codecov Report

Merging #174 into master will decrease coverage by 0.0146%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master       #174        +/-   ##
================================================
- Coverage   53.2678%   53.2532%   -0.0147%     
================================================
  Files           121        121                
  Lines         13648      13648                
================================================
- Hits           7270       7268         -2     
- Misses         5650       5651         +1     
- Partials        728        729         +1

@csuzhangxc
Copy link
Member Author

@amyangfei @GregoryIan PTAL

@IANTHEREAL
Copy link
Collaborator

LGTM

Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyangfei amyangfei added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/WIP This PR is still work in progress labels Jun 14, 2019
@csuzhangxc csuzhangxc merged commit 1173d26 into pingcap:master Jun 14, 2019
@csuzhangxc csuzhangxc deleted the update-parser branch June 14, 2019 08:36
lichunzhu pushed a commit to lichunzhu/dm that referenced this pull request Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/enhancement Performance improvement or refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants