This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csuzhangxc
added
priority/normal
Minor change, requires approval from ≥1 primary reviewer
status/WIP
This PR is still work in progress
type/enhancement
Performance improvement or refactoring
labels
Jun 14, 2019
/run-all-tests |
This reverts commit 136cd0a
Codecov Report
@@ Coverage Diff @@
## master #174 +/- ##
================================================
- Coverage 53.2678% 53.2532% -0.0147%
================================================
Files 121 121
Lines 13648 13648
================================================
- Hits 7270 7268 -2
- Misses 5650 5651 +1
- Partials 728 729 +1 |
@amyangfei @GregoryIan PTAL |
LGTM |
amyangfei
approved these changes
Jun 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
amyangfei
added
status/LGT2
Two reviewers already commented LGTM, ready for merge
and removed
status/WIP
This PR is still work in progress
labels
Jun 14, 2019
lichunzhu
pushed a commit
to lichunzhu/dm
that referenced
this pull request
Apr 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
priority/normal
Minor change, requires approval from ≥1 primary reviewer
status/LGT2
Two reviewers already commented LGTM, ready for merge
type/enhancement
Performance improvement or refactoring
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
update TiDB parser in go.mod to support more DDL statements.
What is changed and how it works?
go: github.com/golang/[email protected]: parsing go.mod: unexpected module path "golang.org/x/lint"
, addedreplace github.com/golang/lint => golang.org/x/lint v0.0.0-20190409202823-959b441ac422
in go.mod, see parsing go.mod: unexpected module path "golang.org/x/lint" golang/lint#446 (comment).replace google.golang.org/grpc => google.golang.org/grpc v1.17.0
in go.mod.Check List
Tests