Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

test: fix unstable wait rpc alive #2095

Merged
merged 1 commit into from
Sep 6, 2021
Merged

test: fix unstable wait rpc alive #2095

merged 1 commit into from
Sep 6, 2021

Conversation

lance6716
Copy link
Collaborator

What problem does this PR solve?

part of #2073

https://ci.pingcap.net/blue/organizations/jenkins/dm_ghpr_new_test/detail/dm_ghpr_new_test/2218/pipeline/ :

  • waiting MySQL2 starting cost 32 * 2s
  • some DM-master printed init nowand dm-master startup ... to stdout
  • some DM-master printed init now to stdout

and https://ci.pingcap.net/blue/organizations/jenkins/dm_ghpr_new_test/detail/dm_ghpr_new_test/2143/pipeline/ :

  • DM-master print nothing

What is changed and how it works?

increase retry from 10 times to 20 times 😂

Check List

Tests

  • No code

Related changes

  • Need to cherry-pick to the release branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 6, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Ehco1996
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@lance6716 lance6716 added the needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 label Sep 6, 2021
@lance6716 lance6716 mentioned this pull request Sep 6, 2021
Open
21 tasks
lichunzhu
lichunzhu approved these changes Sep 6, 2021
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer already commented LGTM label Sep 6, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Sep 6, 2021
@lance6716
Copy link
Collaborator Author

/run-unit-tests

1 similar comment
@lance6716
Copy link
Collaborator Author

/run-unit-tests

@lance6716
Copy link
Collaborator Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4057a79

@ti-chi-bot ti-chi-bot merged commit 5634504 into pingcap:master Sep 6, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 6, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2097.

ti-chi-bot added a commit that referenced this pull request Sep 7, 2021
@ti-chi-bot
test: fix unstable wait rpc alive (#2095) (#2097)
1efd1e7
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ehco1996 Ehco1996 Ehco1996 approved these changes

@lichunzhu lichunzhu lichunzhu approved these changes

@GMHDBJD GMHDBJD Awaiting requested review from GMHDBJD

Assignees
No one assigned
Labels
needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 size/XS status/can-merge status/LGT2 Two reviewers already commented LGTM, ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lance6716 @ti-chi-bot @lichunzhu @Ehco1996