Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scale-tidb-using-tiup.md #16743

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Update scale-tidb-using-tiup.md #16743

merged 3 commits into from
Apr 16, 2024

Conversation

easonn7
Copy link
Collaborator

@easonn7 easonn7 commented Mar 5, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Mar 5, 2024
Copy link

ti-chi-bot bot commented Mar 5, 2024

Hi @easonn7. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 5, 2024
@qiancai qiancai self-assigned this Mar 6, 2024
@qiancai qiancai added the translation/doing This PR’s assignee is translating this PR. label Mar 6, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Mar 6, 2024
@WalterWj
Copy link
Contributor

@easonn7 Any update ?

tiup cluster reload <cluster-name> --skip-restart
```

(2)更新 Prometheus 配置并重启:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

从 tiup cluster v1.15.0 起不再需要第二步了,直接删了吧

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

要不修改为一个 Note,如果用户的 tiup 版本低于 v1.15.0,就需要更新 Prometheus 配置并重启

tiup cluster reload <cluster-name> --skip-restart
```

(2)更新 Prometheus 配置并重启:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

从 tiup cluster v1.15.0 起不再需要第二步了,删除这一小段吧

@WalterWj
Copy link
Contributor

Can this pr be merged as soon as possible?

scale-tidb-using-tiup.md Outdated Show resolved Hide resolved
scale-tidb-using-tiup.md Outdated Show resolved Hide resolved
scale-tidb-using-tiup.md Outdated Show resolved Hide resolved
scale-tidb-using-tiup.md Outdated Show resolved Hide resolved
scale-tidb-using-tiup.md Outdated Show resolved Hide resolved
scale-tidb-using-tiup.md Outdated Show resolved Hide resolved
scale-tidb-using-tiup.md Outdated Show resolved Hide resolved
scale-tidb-using-tiup.md Outdated Show resolved Hide resolved
@CLAassistant
Copy link

CLAassistant commented Apr 16, 2024

CLA assistant check
All committers have signed the CLA.

scale-tidb-using-tiup.md Outdated Show resolved Hide resolved
scale-tidb-using-tiup.md Outdated Show resolved Hide resolved
@lilin90
Copy link
Member

lilin90 commented Apr 16, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Apr 16, 2024
@lilin90 lilin90 added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.0 labels Apr 16, 2024
@qiancai qiancai added the ONCALL Relates to documentation oncall. label Apr 16, 2024
Copy link

ti-chi-bot bot commented Apr 16, 2024

@kaaaaaaang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #17135.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.6: #17136.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.0: #17137.

ti-chi-bot bot pushed a commit that referenced this pull request Apr 16, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Apr 16, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Apr 16, 2024
@qiancai qiancai added the area/tiup Indicates that the Issue or PR belongs to the area of the TiUP tool. label Apr 17, 2024
@qiancai qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Apr 19, 2024
@Oreoxmt Oreoxmt added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Sep 12, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #18617.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #18618.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #18620.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/tiup Indicates that the Issue or PR belongs to the area of the TiUP tool. contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. lgtm needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. ok-to-test Indicates a PR is ready to be tested. ONCALL Relates to documentation oncall. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants