PD: optimize the description of label-property #18526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
missing-translation-status
qiancai
added
needs-cherry-pick-release-8.1
ti-chi-bot
bot
removed
the
missing-translation-status
qiancai
reviewed
Sep 4, 2024
lhy1024
approved these changes
Sep 4, 2024
|
@lhy1024: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
qiancai
reviewed
Sep 6, 2024
pd-configuration-file.md
Outdated
| @@ -430,7 +430,7 @@ pd-server 相关配置项。 | |||
|
|
|||
| ## label-property | |||
|
|
|||
| 标签相关的配置项。 | |||
| 标签相关的配置项，目前只支持 `reject-leader` 类型，后续会逐渐下掉该配置项，建议使用 [Placement Rules](/configure-placement-rules.md#场景二5-副本按-2-2-1-的比例放置在-3-个数据中心且第-3-个中心不产生-leader)。 | |||
There was a problem hiding this comment.
Suggested change
| 标签相关的配置项，目前只支持 `reject-leader` 类型，后续会逐渐下掉该配置项，建议使用 [Placement Rules](/configure-placement-rules.md#场景二5-副本按-2-2-1-的比例放置在-3-个数据中心且第-3-个中心不产生-leader)。 | |
| 标签相关的配置项，目前只支持 `reject-leader` 类型。该配置项计划将在未来版本中废弃，建议使用 [Placement Rules](/configure-placement-rules.md#场景二5-副本按-2-2-1-的比例放置在-3-个数据中心且第-3-个中心不产生-leader) 设置副本策略。 |
qiancai
reviewed
Sep 6, 2024
qiancai
reviewed
Sep 9, 2024
qiancai
approved these changes
Sep 9, 2024
16 tasks
qiancai
reviewed
Sep 10, 2024
ti-chi-bot
bot
added
size/S
qiancai
added
needs-cherry-pick-release-5.3
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
pushed a commit
to ti-chi-bot/docs-cn
that referenced
this pull request
Sep 10, 2024
Signed-off-by: ti-chi-bot <[email protected]>
16 tasks
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
pushed a commit
to ti-chi-bot/docs-cn
that referenced
this pull request
Sep 10, 2024
Signed-off-by: ti-chi-bot <[email protected]>
16 tasks
|
In response to a cherrypick label: new pull request created to branch |
16 tasks
|
In response to a cherrypick label: new pull request created to branch |
16 tasks
|
In response to a cherrypick label: new pull request created to branch |
This was referenced Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?