sys-var: change `tidb_scatter_region` usage definition #18626

Benjamin2037 · 2024-09-13T01:30:04Z

First-time contributors' checklist

I've signed Contributor License Agreement that's required for repo owners to accept my contribution.

What is changed, added or deleted? (Required)

As title mentioned.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

ti-chi-bot · 2024-09-13T01:39:28Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from hfxsd, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

system-variables.md

Co-authored-by: xixirangrang <[email protected]>

system-variables.md

River2000i

/LGTM

ti-chi-bot · 2024-09-13T07:02:46Z

@River2000i: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot · 2024-09-14T03:31:52Z

@niubell: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

system-variables.md

Co-authored-by: Frank945946 <[email protected]>

River2000i · 2024-09-18T07:44:27Z

system-variables.md

@@ -4149,12 +4149,16 @@ EXPLAIN FORMAT='brief' SELECT COUNT(1) FROM t WHERE a = 1 AND b IS NOT NULL;

 ### `tidb_scatter_region`

- 作用域：GLOBAL
+- 作用域：SESSION | GLOBAL


should we keep the original global level?

Yes，Current implement should add session level sys var change and also keep global level implementation.

system-variables.md

lilin90 · 2024-09-23T07:54:48Z

system-variables.md

- TiDB 默认会在建表时为新表分裂 Region。开启该变量后，会在建表语句执行时，同步打散刚分裂出的 Region。适用于批量建表后紧接着批量写入数据，能让刚分裂出的 Region 先在 TiKV 分散而不用等待 PD 进行调度。为了保证后续批量写入数据的稳定性，建表语句会等待打散 Region 完成后再返回建表成功，建表语句执行时间会是该变量关闭时的数倍。
+- 类型：枚举型
+- 默认值：``
+- 可选值：``，`TABLE`，`GLOBAL`


@hfxsd 后续需要关注下 PR 合并后官方文档的效果，第一个空的可选值导致 GitHub 页面解析有问题：

system-variables.md

Update tidb_scatter_region usage for new definition.

1b1518f

ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 13, 2024

Benjamin2037 requested review from D3Hunter, hfxsd and Frank945946 September 13, 2024 01:31

hfxsd self-assigned this Sep 13, 2024

hfxsd added v8.4 This PR/issue applies to TiDB v8.4. translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Sep 13, 2024

Add sesssion level support.

49de5b9

hfxsd added the type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. label Sep 13, 2024

hfxsd reviewed Sep 13, 2024

View reviewed changes