Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys-var: change tidb_scatter_region usage definition #18626

Merged
merged 14 commits into from
Oct 15, 2024
Merged

sys-var: change tidb_scatter_region usage definition #18626

merged 14 commits into from
Oct 15, 2024

Conversation

Benjamin2037
Copy link
Contributor

@Benjamin2037 Benjamin2037 commented Sep 13, 2024 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

As title mentioned.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 13, 2024
@hfxsd hfxsd self-assigned this Sep 13, 2024
@hfxsd hfxsd added v8.4 This PR/issue applies to TiDB v8.4. translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Sep 13, 2024
@hfxsd hfxsd added the type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. label Sep 13, 2024
hfxsd
hfxsd reviewed Sep 13, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Sep 13, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@Benjamin2037 @hfxsd
Update system-variables.md
cf18201 
Co-authored-by: xixirangrang <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 13, 2024
hfxsd
hfxsd reviewed Sep 13, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@hfxsd hfxsd changed the title Change tidb_scatter_region usage definition. sys-var: change tidb_scatter_region usage definition Sep 13, 2024
@hfxsd hfxsd mentioned this pull request Sep 13, 2024
Merged
16 tasks
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Sep 13, 2024
hfxsd
hfxsd reviewed Sep 13, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Sep 13, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
River2000i
River2000i reviewed Sep 13, 2024
View reviewed changes
Copy link

@River2000i River2000i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 13, 2024

@River2000i: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Frank945946
Frank945946 reviewed Sep 14, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@Benjamin2037 @Frank945946
Update system-variables.md
3ee904a 
Co-authored-by: Frank945946 <[email protected]>
jebter
jebter reviewed Sep 19, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Sep 19, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@hfxsd hfxsd requested a review from lilin90 September 19, 2024 06:35
lilin90
lilin90 reviewed Sep 23, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
lilin90
lilin90 reviewed Sep 23, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
lilin90
lilin90 reviewed Sep 23, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Sep 26, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Sep 26, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
lilin90
lilin90 reviewed Sep 26, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
lilin90
lilin90 reviewed Oct 8, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
lilin90
lilin90 approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 8, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 9, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-08 07:36:28.256084299 +0000 UTC m=+945143.676297307: ☑️ agreed by lilin90.
  • 2024-10-09 02:18:38.476610878 +0000 UTC m=+1012473.896823890: ☑️ agreed by hfxsd.

@hfxsd
Copy link
Collaborator

hfxsd commented Oct 15, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 15, 2024
@ti-chi-bot ti-chi-bot bot merged commit 79300ca into pingcap:master Oct 15, 2024
7 checks passed
@Oreoxmt Oreoxmt mentioned this pull request Oct 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frank945946 Frank945946 Frank945946 left review comments

@River2000i River2000i River2000i left review comments

@jebter jebter jebter left review comments

@hfxsd hfxsd hfxsd approved these changes

@lilin90 lilin90 lilin90 approved these changes

@niubell niubell niubell approved these changes

@D3Hunter D3Hunter Awaiting requested review from D3Hunter

Assignees

@hfxsd hfxsd

Labels
approved lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v8.4 This PR/issue applies to TiDB v8.4.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Benjamin2037 @hfxsd @jebter @niubell @lilin90 @River2000i @Frank945946