Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiflash: remove deprecated http_port #18868

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+2 −3
Open

tiflash: remove deprecated http_port #18868

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
283d336
tiflash: remove deprecated http_port
Lloyd-Pottiger Oct 18, 2024
db1aad8
address comments
Lloyd-Pottiger Oct 18, 2024
a69b2c8
Apply suggestions from code review
Lloyd-Pottiger Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion enable-tls-between-components.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ aliases: ['/docs-cn/dev/enable-tls-between-components/','/docs-cn/dev/how-to/sec

- TiFlash（从 v4.0.5 版本开始引入）

在 `tiflash.toml` 文件中设置，将 `http_port` 项改为 `https_port`:
在 `tiflash.toml` 文件中设置,
Lloyd-Pottiger marked this conversation as resolved.
Show resolved Hide resolved

```toml
[security]
Expand Down
3 changes: 1 addition & 2 deletions tiup/tiup-cluster-topology-reference.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ tikv_servers:

- `host`：指定部署到哪台机器，字段值填 IP 地址，不可省略
- `ssh_port`：指定连接目标机器进行操作的时候使用的 SSH 端口，若不指定，则使用 global 区块中的 `ssh_port`
- `tcp_port`：TiFlash TCP 服务的端口，默认 9000
- `tcp_port`：TiFlash TCP 服务的端口，用于执行测试，默认 9000。自 tiup v1.12.5 起，如果部署的集群版本 >= v7.1.0，则该配置项不生效
Lloyd-Pottiger marked this conversation as resolved.
Show resolved Hide resolved
- `flash_service_port`：TiFlash 提供服务的端口，TiDB 通过该端口从 TiFlash 读数据，默认 3930
- `metrics_port`：TiFlash 的状态端口，用于输出 metric 数据，默认 8234
- `flash_proxy_port`：内置 TiKV 的端口，默认 20170
Expand All @@ -315,7 +315,6 @@ tikv_servers:

- `host`
- `tcp_port`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

298 行改一下：

  • tcp_port：TiFlash TCP 服务的端口，用于执行测试，默认 9000。自 tiup v1.12.5 起，如果部署的集群版本 >= v7.1.0，则该配置项不生效。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

- `http_port`
- `flash_service_port`
- `flash_proxy_port`
- `flash_proxy_status_port`
Expand Down
Loading