Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a JSON function typo #18879

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Conversation

lilin90
Copy link
Member

@lilin90 lilin90 commented Oct 21, 2024

What is changed, added or deleted? (Required)

Fixes a JSON function typo introduced in #17784: JSON_DEPTH() to JSON_LENGTH().

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@lilin90 lilin90 added translation/no-need No need to translate this PR. ONCALL Relates to documentation oncall. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.2 Should cherry pick this PR to release-8.2 branch. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. labels Oct 21, 2024
@lilin90 lilin90 self-assigned this Oct 21, 2024
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 21, 2024
@lilin90 lilin90 added the lgtm label Oct 21, 2024
@lilin90
Copy link
Member Author

lilin90 commented Oct 21, 2024

/approve

Copy link

ti-chi-bot bot commented Oct 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 21, 2024
@ti-chi-bot ti-chi-bot bot merged commit f8be92b into pingcap:master Oct 21, 2024
7 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #18881.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 21, 2024
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.2: #18882.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 21, 2024
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.3: #18883.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 21, 2024
15 tasks
@lilin90 lilin90 deleted the fix-json-function-typo branch October 21, 2024 09:28
ti-chi-bot bot pushed a commit that referenced this pull request Oct 21, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Oct 21, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.2 Should cherry pick this PR to release-8.2 branch. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. ONCALL Relates to documentation oncall. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/no-need No need to translate this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants