Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiup: use tibd operator to rollback tidb #2599

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

hfxsd
Copy link
Collaborator

@hfxsd hfxsd commented Jul 23, 2024

First-time contributors' checklist

What is changed, added, or deleted? (Required)

Which TiDB Operator version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v1.6 (TiDB Operator 1.6 versions)
  • v1.5 (TiDB Operator 1.5 versions)
  • v1.4 (TiDB Operator 1.4 versions)
  • v1.3 (TiDB Operator 1.3 versions)
  • v1.2 (TiDB Operator 1.2 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@hfxsd hfxsd self-assigned this Jul 23, 2024
Copy link

ti-chi-bot bot commented Jul 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from hfxsd, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. labels Jul 23, 2024
@hfxsd hfxsd added needs-cherry-pick-release-1.6 Should cherry pick this PR to release-1.6 branch. and removed missing-translation-status This PR does not have translation status info. labels Jul 23, 2024
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 23, 2024
@hfxsd hfxsd added translation/doing This PR’s assignee is translating this PR. and removed contribution This PR is from a community contributor. labels Jul 23, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 23, 2024
zh/roll-back-a-tidb-cluster.md Outdated Show resolved Hide resolved
zh/roll-back-a-tidb-cluster.md Outdated Show resolved Hide resolved
zh/roll-back-a-tidb-cluster.md Outdated Show resolved Hide resolved
zh/roll-back-a-tidb-cluster.md Outdated Show resolved Hide resolved
Copy link

ti-chi-bot bot commented Jul 23, 2024

@Frank945946: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 23, 2024
zh/roll-back-a-tidb-cluster.md Outdated Show resolved Hide resolved
Copy link

ti-chi-bot bot commented Jul 23, 2024

@Frank945946: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zh/roll-back-a-tidb-cluster.md Outdated Show resolved Hide resolved
zh/roll-back-a-tidb-cluster.md Outdated Show resolved Hide resolved
@JasonWu0506
Copy link

if there is only 1 tidb, rollback will break all the connection from client, which means custoemr's app will be down. if multi-instances of tidb, there should be no down.
please doc team review the wording

zh/roll-back-a-tidb-cluster.md Outdated Show resolved Hide resolved
zh/roll-back-a-tidb-cluster.md Outdated Show resolved Hide resolved
Copy link

ti-chi-bot bot commented Jul 25, 2024

@Frank945946: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zh/roll-back-a-tidb-cluster.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-1.6 Should cherry pick this PR to release-1.6 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/doing This PR’s assignee is translating this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants