Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add security configuration documentation and migrate security docs di… #18996

Merged
merged 4 commits into from
Oct 12, 2024

Conversation

TopScrew
Copy link
Contributor

@TopScrew TopScrew commented Sep 24, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add TiDB security configuration best practices and migrate security hardening docs directory

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@CLAassistant
Copy link

CLAassistant commented Sep 24, 2024

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. labels Sep 24, 2024
Copy link

ti-chi-bot bot commented Sep 24, 2024

Hi @TopScrew. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 24, 2024
@TopScrew
Copy link
Contributor Author

/ok-to-test

Copy link

ti-chi-bot bot commented Sep 24, 2024

@TopScrew: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lilin90 lilin90 added requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Sep 26, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Sep 26, 2024
@lilin90
Copy link
Member

lilin90 commented Sep 26, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Sep 26, 2024
@qiancai qiancai self-requested a review October 8, 2024 10:03
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Oct 10, 2024

@bb7133: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

best-practices-for-security-configuration.md Outdated Show resolved Hide resolved
best-practices-for-security-configuration.md Outdated Show resolved Hide resolved
best-practices-for-security-configuration.md Outdated Show resolved Hide resolved
best-practices-for-security-configuration.md Outdated Show resolved Hide resolved
best-practices-for-security-configuration.md Outdated Show resolved Hide resolved
best-practices-for-security-configuration.md Outdated Show resolved Hide resolved
best-practices-for-security-configuration.md Outdated Show resolved Hide resolved
best-practices-for-security-configuration.md Outdated Show resolved Hide resolved
best-practices-for-security-configuration.md Outdated Show resolved Hide resolved
best-practices-for-security-configuration.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 10, 2024
@qiancai qiancai self-assigned this Oct 10, 2024
best-practices-for-security-configuration.md Outdated Show resolved Hide resolved
best-practices-for-security-configuration.md Outdated Show resolved Hide resolved
best-practices-for-security-configuration.md Outdated Show resolved Hide resolved
best-practices-for-security-configuration.md Outdated Show resolved Hide resolved
best-practices-for-security-configuration.md Outdated Show resolved Hide resolved
best-practices-for-security-configuration.md Outdated Show resolved Hide resolved
best-practices-for-security-configuration.md Outdated Show resolved Hide resolved
best-practices-for-security-configuration.md Outdated Show resolved Hide resolved
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 12, 2024
Copy link

ti-chi-bot bot commented Oct 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-10 07:09:16.176939642 +0000 UTC m=+1116311.597152649: ☑️ agreed by qiancai.
  • 2024-10-12 07:06:30.21172529 +0000 UTC m=+81987.360635114: ☑️ agreed by lilin90.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Oct 12, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #19093.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Oct 12, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.3: #19094.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Oct 12, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #19095.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Oct 12, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #19096.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.3: #19097.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #19098.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #19099.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.2: #19100.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. lgtm needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.2 Should cherry pick this PR to release-8.2 branch. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. ok-to-test Indicates a PR is ready to be tested. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants