Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloud: serverless HA #19500

Open
wants to merge 8 commits into
base: release-7.5
Choose a base branch
from
Open

cloud: serverless HA #19500

wants to merge 8 commits into from
+117 −1

Conversation

shizn
Copy link
Contributor

@shizn shizn commented Nov 26, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 26, 2024
@Oreoxmt Oreoxmt self-requested a review November 26, 2024 04:11
@Oreoxmt Oreoxmt added translation/no-need No need to translate this PR. area/tidb-cloud This PR relates to the area of TiDB Cloud. for-cloud-release This PR is related to TiDB Cloud release. labels Nov 26, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Nov 26, 2024
@Oreoxmt Oreoxmt self-assigned this Nov 26, 2024
sunxiaoguang
sunxiaoguang approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@sunxiaoguang sunxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 26, 2024

@sunxiaoguang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from oreoxmt, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Oreoxmt
Oreoxmt reviewed Nov 26, 2024
View reviewed changes
TOC-tidb-cloud.md Outdated Show resolved Hide resolved
@Oreoxmt Oreoxmt added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Nov 26, 2024
github-actions bot pushed a commit to Oreoxmt/pingcap-docsite-preview that referenced this pull request Nov 26, 2024
Preview PR pingcap/docs#19500 and this preview is triggered from commit
e0600ca 
pingcap/docs@ad8ca9d
@hfxsd hfxsd self-requested a review November 26, 2024 07:20
Oreoxmt
Oreoxmt reviewed Nov 26, 2024
View reviewed changes
tidb-cloud/serverless-high-availability.md
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preview: https://pingcap-docsite-preview-git-preview-cl-d5eb3d-oreoxmts-projects.vercel.app/tidbcloud/serverless-high-availability

github-actions bot pushed a commit to Oreoxmt/pingcap-docsite-preview that referenced this pull request Nov 26, 2024
Preview PR pingcap/docs#19500 and this preview is triggered from commit
94ed1ea 
pingcap/docs@1c3a8df
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Nov 26, 2024

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 26, 2024
hfxsd
hfxsd reviewed Nov 26, 2024
View reviewed changes
tidb-cloud/serverless-high-availability.md
> **Note:**
>
> - Regional high availability is currently in beta and only available in the AWS Tokyo (`ap-northeast-1`) region.
> - You can enable regional high availability only during cluster creation.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any UI changes for the regional HA? If yes, we also need to update this doc https://docs.pingcap.com/tidbcloud/create-tidb-cluster-serverless

@Oreoxmt @hfxsd
revise wording
30e3b8a 
Co-authored-by: xixirangrang <[email protected]>
Oreoxmt
Oreoxmt approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 3, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-03 02:49:07.643631349 +0000 UTC m=+1123135.263285859: ☑️ agreed by Oreoxmt.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfxsd hfxsd hfxsd left review comments

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@sunxiaoguang sunxiaoguang sunxiaoguang approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
area/tidb-cloud This PR relates to the area of TiDB Cloud. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. for-cloud-release This PR is related to TiDB Cloud release. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/no-need No need to translate this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shizn @Oreoxmt @sunxiaoguang @hfxsd