Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update hardware-and-software-requirements.md #19539

Merged
merged 6 commits into from
Dec 3, 2024
Merged

Update hardware-and-software-requirements.md #19539

merged 6 commits into from
Dec 3, 2024

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Nov 29, 2024 •
edited
Loading

Fix OS supported list:

  • remove Red Hat Enterprise Linux 7.x

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 29, 2024
@wuhuizuo wuhuizuo linked an issue Nov 29, 2024 that may be closed by this pull request
Needs update the "OS and platform requirements" chapter for TiDB v8.4+ versions #19538
Closed
@qiancai qiancai self-assigned this Dec 2, 2024
@qiancai qiancai added the translation/doing This PR's assignee is translating this PR. label Dec 2, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Dec 2, 2024
@qiancai qiancai added the needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. label Dec 2, 2024
@qiancai qiancai requested a review from bb7133 December 2, 2024 08:59
@wuhuizuo
Update hardware-and-software-requirements.md
75ff5c7 
Fix OS supported list:
- remove Red Hat Enterprise Linux 7.x
@JasonWu0506
Copy link

LGTM

bb7133
bb7133 approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 3, 2024

@bb7133: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 3, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 3, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-03 05:36:45.740416283 +0000 UTC m=+1133193.360070793: ☑️ agreed by qiancai.

@qiancai qiancai mentioned this pull request Dec 3, 2024
Merged
17 tasks
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 3, 2024
qiancai
qiancai reviewed Dec 3, 2024
View reviewed changes
releases/release-8.4.0.md Outdated Show resolved Hide resolved
@qiancai qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Dec 3, 2024
qiancai
qiancai reviewed Dec 3, 2024
View reviewed changes
releases/release-8.4.0.md Outdated Show resolved Hide resolved
This was referenced Dec 3, 2024
Merged
Merged
@qiancai
Copy link
Collaborator

qiancai commented Dec 3, 2024

/approve

@qiancai qiancai added the lgtm label Dec 3, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 3, 2024
@ti-chi-bot ti-chi-bot bot merged commit a6ed826 into master Dec 3, 2024
8 of 9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.4: #19555.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 3, 2024
Merged
17 tasks
@qiancai qiancai added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Dec 3, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #19557.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 3, 2024
Merged
17 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Dec 3, 2024
@ti-chi-bot
Update hardware-and-software-requirements.md (#19539) (#19555)
630e445
ti-chi-bot bot pushed a commit that referenced this pull request Dec 3, 2024
@ti-chi-bot
Update hardware-and-software-requirements.md (#19539) (#19557)
99273e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai approved these changes

@bb7133 bb7133 bb7133 approved these changes

@stevenayu stevenayu Awaiting requested review from stevenayu

Assignees

@qiancai qiancai

Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Needs update the "OS and platform requirements" chapter for TiDB v8.4+ versions
5 participants
@wuhuizuo @JasonWu0506 @qiancai @ti-chi-bot @bb7133