Skip to content

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented Oct 15, 2025

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 15, 2025
Copy link

ti-chi-bot bot commented Oct 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign overvenus for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the missing-translation-status This PR does not have translation status info. label Oct 15, 2025
Copy link

Summary of Changes

Hello @qiancai, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces the official release notes for TiDB 8.5.4. The new documentation outlines compatibility changes, various improvements across TiDB, TiKV, PD, and related tools, as well as critical bug fixes. The PR is currently marked as a Work In Progress, indicating further content or review might be needed before finalization.

Highlights

  • New Release Notes Added: A new Markdown file, releases/release-8.5.4.md, has been added to document the release notes for TiDB version 8.5.4.
  • Compatibility Changes: The release notes include a significant compatibility change in TiKV, deprecating several region-compact configuration items and replacing them with a new gc.auto-compaction configuration group for better control over automatic compaction behavior.
  • Improvements: Key improvements highlighted include support for creating global indexes on non-unique columns of partitioned tables in TiDB, the ability to apply the semi_join_rewrite hint to Semi Joins in IN subqueries, optimization of tail latency for async snapshot and write operations in TiKV, and a reduction of unnecessary error logs in PD.
  • Bug Fixes: Notable bug fixes address issues such as significantly overestimated row count estimates across months or years in TiDB and an improper initialization of the PD client retry policy.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 15, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the release notes for TiDB v8.5.4. The file appears to be a work in progress, containing several placeholders and entries with internal duplication markers. My review focuses on cleaning up these entries to align with the documentation style, updating outdated links, and removing placeholders. I've provided specific suggestions for each duplicated entry to make them ready for the final version. Also, please ensure the file ends with a newline character for consistency.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
+ Backup & Restore (BR)

- note [#issue](https://github.com/pingcap/tidb/issues/${issue-id}) @[Contributor GitHub ID](https://github.com/${github-id})
- note [#issue](https://github.com/pingcap/tidb/issues/${issue-id}) @[Contributor GitHub ID](https://github.com/${github-id})
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v8.5.3 already includes the following issue for tikv/tikv#18615. Now in v8.5.4, there is another PR tikv/tikv#18783 for the same issue. Should we use the same release note in v8.5.4?

Fix the issue that log backup uploads to Azure Blob Storage are slow when transferring large volumes of data #18410 @YuJuncen

## Improvements

+ TiDB

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v8.5.3 already includes the following issue for pingcap/tidb#62232. Now in v8.5.4, there is another PR pingcap/tidb#63485 for the same issue. Should we use the same release note in v8.5.4?

- Add flow control interfaces for Region splitting and data ingestion during data import [#61553](https://github.com/pingcap/tidb/issues/61553) @[tangenta](https://github.com/tangenta)

- (dup): release-7.5.7.md > Bug fixes> TiDB - Fix the issue that row count estimates across months or years can be significantly overestimated [#50080](https://github.com/pingcap/tidb/issues/50080) @[terry1purcell](https://github.com/terry1purcell)

+ TiKV

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v8.5.3 already includes the following issue for pingcap/tidb#62232. Now in v8.5.4, there is another PR tikv/tikv#18581 for the same issue. Should we use the same release note in v8.5.4?

- Optimize the handling of `CompactedEvent` in Raftstore by moving it to the `split-check` worker, reducing blocking on the main Raftstore thread [#18532](https://github.com/tikv/tikv/issues/18532) @[LykxSassinator](https://github.com/LykxSassinator)


+ Backup & Restore (BR)

- note [#issue](https://github.com/pingcap/tidb/issues/${issue-id}) @[Contributor GitHub ID](https://github.com/${github-id})
Copy link
Contributor

@YuJuncen YuJuncen Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Fix the issue where Zstd compression did not take effect in log backup, resulting in uncompressed output. #18836 @3pointer
  • Fixed a bug that may cause flush operation slow in azure blob storage. #18410 @YuJuncen
  • Fixed a bug that may cause log truncate panic when failed to delete file. #63358 @YuJuncen
  • Fixed a bug that may cause stats_meta be zero when checksumming disabled. #60978 @Leavrth
  • Reduced chance of BR restore failure from S3-compatible storage when the S3 server limits bandwidth through traffic shaping. #18846 @kennytm
  • Fix the issue that the log backup observer loses observation of a region. #18243 @Leavrth
  • Fixed a a bug that may cause restore point fail when there are some special sized table schemas. #63663 @RidRisR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants