-
Notifications
You must be signed in to change notification settings - Fork 705
[WIP]: add v8.5.4 release notes #21913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary of ChangesHello @qiancai, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces the official release notes for TiDB 8.5.4. The new documentation outlines compatibility changes, various improvements across TiDB, TiKV, PD, and related tools, as well as critical bug fixes. The PR is currently marked as a Work In Progress, indicating further content or review might be needed before finalization. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds the release notes for TiDB v8.5.4. The file appears to be a work in progress, containing several placeholders and entries with internal duplication markers. My review focuses on cleaning up these entries to align with the documentation style, updating outdated links, and removing placeholders. I've provided specific suggestions for each duplicated entry to make them ready for the final version. Also, please ensure the file ends with a newline character for consistency.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
+ Backup & Restore (BR) | ||
|
||
- note [#issue](https://github.com/pingcap/tidb/issues/${issue-id}) @[Contributor GitHub ID](https://github.com/${github-id}) | ||
- note [#issue](https://github.com/pingcap/tidb/issues/${issue-id}) @[Contributor GitHub ID](https://github.com/${github-id}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v8.5.3 already includes the following issue for tikv/tikv#18615. Now in v8.5.4, there is another PR tikv/tikv#18783 for the same issue. Should we use the same release note in v8.5.4?
Fix the issue that log backup uploads to Azure Blob Storage are slow when transferring large volumes of data #18410 @YuJuncen
## Improvements | ||
|
||
+ TiDB | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v8.5.3 already includes the following issue for pingcap/tidb#62232. Now in v8.5.4, there is another PR pingcap/tidb#63485 for the same issue. Should we use the same release note in v8.5.4?
- Add flow control interfaces for Region splitting and data ingestion during data import [#61553](https://github.com/pingcap/tidb/issues/61553) @[tangenta](https://github.com/tangenta)
- (dup): release-7.5.7.md > Bug fixes> TiDB - Fix the issue that row count estimates across months or years can be significantly overestimated [#50080](https://github.com/pingcap/tidb/issues/50080) @[terry1purcell](https://github.com/terry1purcell) | ||
|
||
+ TiKV | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v8.5.3 already includes the following issue for pingcap/tidb#62232. Now in v8.5.4, there is another PR tikv/tikv#18581 for the same issue. Should we use the same release note in v8.5.4?
- Optimize the handling of `CompactedEvent` in Raftstore by moving it to the `split-check` worker, reducing blocking on the main Raftstore thread [#18532](https://github.com/tikv/tikv/issues/18532) @[LykxSassinator](https://github.com/LykxSassinator)
|
||
+ Backup & Restore (BR) | ||
|
||
- note [#issue](https://github.com/pingcap/tidb/issues/${issue-id}) @[Contributor GitHub ID](https://github.com/${github-id}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Fix the issue where Zstd compression did not take effect in log backup, resulting in uncompressed output. #18836 @3pointer
- Fixed a bug that may cause flush operation slow in azure blob storage. #18410 @YuJuncen
- Fixed a bug that may cause
log truncate
panic when failed to delete file. #63358 @YuJuncen - Fixed a bug that may cause
stats_meta
be zero when checksumming disabled. #60978 @Leavrth - Reduced chance of BR restore failure from S3-compatible storage when the S3 server limits bandwidth through traffic shaping. #18846 @kennytm
- Fix the issue that the log backup observer loses observation of a region. #18243 @Leavrth
- Fixed a a bug that may cause
restore point
fail when there are some special sized table schemas. #63663 @RidRisR
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?