Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TiKV config: Add quota-related configurations #7978

Merged
merged 8 commits into from
Mar 31, 2022
Merged

TiKV config: Add quota-related configurations #7978

merged 8 commits into from
Mar 31, 2022

Conversation

en-jin19
Copy link
Contributor

What is changed, added or deleted? (Required)

  • Added the description about Quota Limiter feature
  • Added the quota-related configurations: foreground-cpu-time, foreground-write-bandwidth, foreground-read-bandwidth, max-delay-duration

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@en-jin19 en-jin19 added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.0 This PR/issue applies to TiDB v6.0. labels Mar 28, 2022
@en-jin19 en-jin19 requested review from hunterlxt and TomShawn March 28, 2022 14:48
@en-jin19 en-jin19 self-assigned this Mar 28, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 28, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 28, 2022
en-jin19
en-jin19 commented Mar 28, 2022
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
@en-jin19 en-jin19 added the status/PTAL This PR is ready for reviewing. label Mar 29, 2022
hunterlxt
hunterlxt approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@hunterlxt hunterlxt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

tikv-configuration-file.md Outdated

Configuration items related to Quota Limiter.

Suppose that your machine deployed TiKV has limited resources, for example, 4v CPU, 16 G memory. In this case, if the amount of requests processed by TiKV in the foreground is too large, the CPU resources for background processing are occupied by the foreground, causing TiKV performance to degrade. To avoid this issue, you can use the quota-related configuration items to limit the CPU resources used by the foreground. When requests trigger the Quota Limiter feature, the requests are forced to wait for a while to free up CPU resources. The exact waiting time depends on the amount of the requests, and the maximum waiting time is no longer than the value of [`max-delay-duration`](#max-delay-durationnew-in-v600).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure whether right "16 G" -> "16G"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We generally use the format of adding a blank between a number and a unit (16 G) and revise contents that do not meet this rule. However, there are some special cases, and one of them is the format of values: if it is a value of a configuration item, we use 16G or 16 GB according to different circumstances.

TomShawn
TomShawn reviewed Mar 29, 2022
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
tikv-configuration-file.md Outdated Show resolved Hide resolved
tikv-configuration-file.md Outdated Show resolved Hide resolved
tikv-configuration-file.md Outdated Show resolved Hide resolved
tikv-configuration-file.md Outdated Show resolved Hide resolved
tikv-configuration-file.md Outdated Show resolved Hide resolved
tikv-configuration-file.md Outdated Show resolved Hide resolved
tikv-configuration-file.md Outdated Show resolved Hide resolved
tikv-configuration-file.md Outdated Show resolved Hide resolved
tikv-configuration-file.md Outdated Show resolved Hide resolved
en-jin19
en-jin19 commented Mar 29, 2022
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
en-jin19
en-jin19 commented Mar 29, 2022
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
en-jin19
en-jin19 commented Mar 29, 2022
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
en-jin19
en-jin19 commented Mar 29, 2022
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
en-jin19
en-jin19 commented Mar 30, 2022
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
@en-jin19
Copy link
Contributor Author

@TomShawn all comments have been addressed, PTAL, thanks!

TomShawn
TomShawn approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 31, 2022
en-jin19
en-jin19 commented Mar 31, 2022
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
@en-jin19
Copy link
Contributor Author

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 31, 2022
@en-jin19
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d234121

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 31, 2022
@ti-chi-bot ti-chi-bot merged commit ecac1ec into pingcap:master Mar 31, 2022
@en-jin19 en-jin19 removed the status/PTAL This PR is ready for reviewing. label Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@hunterlxt hunterlxt hunterlxt approved these changes

Assignees

@en-jin19 en-jin19

Labels
area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.0 This PR/issue applies to TiDB v6.0.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@en-jin19 @ti-chi-bot @hunterlxt @TomShawn