Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json-functions: Update status and links #8762

Merged
merged 2 commits into from
Jun 7, 2022
Merged

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented May 30, 2022

What is changed, added or deleted? (Required)

Update the status of JSON functions in TiDB

mysql> CREATE TABLE t3 (id int primary key auto_increment, o_id int, attribute varchar(255), value varchar(255));
Query OK, 0 rows affected (0.12 sec)

mysql> INSERT INTO t3(o_id, attribute, value) VALUES(2,'color','red'),(2,'fabric','silk'),(3,'color','green'),(3,'shape','square');
Query OK, 4 rows affected (0.02 sec)
Records: 4  Duplicates: 0  Warnings: 0

mysql> SELECT o_id, attribute, value FROM t3;
+------+-----------+--------+
| o_id | attribute | value  |
+------+-----------+--------+
|    2 | color     | red    |
|    2 | fabric    | silk   |
|    3 | color     | green  |
|    3 | shape     | square |
+------+-----------+--------+
4 rows in set (0.00 sec)

mysql> SELECT o_id, JSON_ARRAYAGG(attribute) AS attributes
    -> FROM t3 GROUP BY o_id;
+------+---------------------+
| o_id | attributes          |
+------+---------------------+
|    3 | ["color", "shape"]  |
|    2 | ["color", "fabric"] |
+------+---------------------+
2 rows in set (0.01 sec)

mysql> SELECT tidb_version()\G
*************************** 1. row ***************************
tidb_version(): Release Version: v6.0.0
Edition: Community
Git Commit Hash: 36a9810441ca0e496cbd22064af274b3be771081
Git Branch: heads/refs/tags/v6.0.0
UTC Build Time: 2022-03-31 10:33:28
GoVersion: go1.18
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.01 sec)

mysql> SELECT JSON_PRETTY('{"k":"v"}');
+--------------------------+
| JSON_PRETTY('{"k":"v"}') |
+--------------------------+
| {
  "k": "v"
}           |
+--------------------------+
1 row in set (0.00 sec)

mysql> SELECT JSON_MERGE_PATCH('[1, 2]', '[true, false]');
+---------------------------------------------+
| JSON_MERGE_PATCH('[1, 2]', '[true, false]') |
+---------------------------------------------+
| [true, false]                               |
+---------------------------------------------+
1 row in set (0.00 sec)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.1 (TiDB 6.1 versions)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 30, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 30, 2022
@dveeden dveeden requested review from TomShawn and qiancai May 30, 2022 07:09
@TomShawn TomShawn requested review from yiwen92 and tangenta May 30, 2022 07:21
@TomShawn TomShawn self-assigned this May 30, 2022
@TomShawn TomShawn added type/enhancement The issue or PR belongs to an enhancement. translation/doing This PR's assignee is translating this PR. area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. ONCALL Relates to documentation oncall. and removed missing-translation-status This PR does not have translation status info. labels May 30, 2022
@dveeden
Copy link
Contributor Author

dveeden commented May 30, 2022

Note that pingcap/tidb#7968 lists this as not-yet-implemented JSON support:

Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some suggestion on fixing rendering issues.

@@ -103,6 +98,8 @@ The following JSON functions are unsupported in TiDB. You can track the progress

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this renders correctly, please format this whole paragraph as the two first bullet points.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the context of your comment got lost somehow. It also looks like it is already fixed. Could you check if this is really the case and resolve this discussion?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Here you can see that only the two first lines with the * are shown, so I assume there is some issue with the formatting/rendering that we should fix, otherwise the additions will not be seen anyway.

@mjonss
Copy link
Contributor

mjonss commented May 30, 2022

json_pretty included in #24675.
json_merge_patch included in #24711.
json_arrayagg included in #19957.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 30, 2022
Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion to fix the formatting/rendering of 'See also' paragraph.

@@ -103,6 +98,8 @@ The following JSON functions are unsupported in TiDB. You can track the progress

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Here you can see that only the two first lines with the * are shown, so I assume there is some issue with the formatting/rendering that we should fix, otherwise the additions will not be seen anyway.

@dveeden
Copy link
Contributor Author

dveeden commented May 31, 2022

Suggestion to fix the formatting/rendering of 'See also' paragraph.

No this is as intended.

The lines like this should not end up in the doc directly:

[json_pretty]: https://dev.mysql.com/doc/refman/5.7/en/json-utility-functions.html#function_json-pretty

But this allows lines like this to reference the URL:

| [JSON_PRETTY(json_doc)][json_pretty] | Pretty formatting of a JSON document |

Another option would be to combine the two lines like this:

| [JSON_PRETTY(json_doc)][https://dev.mysql.com/doc/refman/5.7/en/json-utility-functions.html#function_json-pretty] | Pretty formatting of a JSON document |

But then the markdown table gets difficult to read due to the long lines.

The problem with formatting that I fixed was related to this, there were functions that had a reference that was not defined, so it couldn't format the link properly.

@dveeden
Copy link
Contributor Author

dveeden commented May 31, 2022

Here you can see the json_storage_size and json_objectagg references that aren't defined anywhere in the current doc:
image

@dveeden
Copy link
Contributor Author

dveeden commented May 31, 2022

PTAL @TomShawn @qiancai

Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 7, 2022
@shichun-0415
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2facd3f

@dveeden
Copy link
Contributor Author

dveeden commented Jun 20, 2022

/cherry-pick release-6.1
/cherry-pick release-5.4
/cherry-pick release-5.3
/cherry-pick release-5.2
/cherry-pick release-5.1

v6.1.0

sql> SELECT JSON_MERGE_PATCH('[1, 2]', '[true, false]') a, JSON_PRETTY('{}') b, (SELECT JSON_ARRAYAGG(x) FROM (SELECT 'a' x UNION ALL SELECT 'b') a) c, tidb_version()\G
*************************** 1. row ***************************
             a: [true, false]
             b: {}
             c: ["a", "b"]
tidb_version(): Release Version: v6.1.0
Edition: Community
Git Commit Hash: 1a89decdb192cbdce6a7b0020d71128bc964d30f
Git Branch: heads/refs/tags/v6.1.0
UTC Build Time: 2022-06-05 05:15:11
GoVersion: go1.18.2
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.0023 sec)

v6.0.0

sql> SELECT JSON_MERGE_PATCH('[1, 2]', '[true, false]') a, JSON_PRETTY('{}') b, (SELECT JSON_ARRAYAGG(x) FROM (SELECT 'a' x UNION ALL SELECT 'b') a) c, tidb_version()\G
*************************** 1. row ***************************
             a: [true, false]
             b: {}
             c: ["a", "b"]
tidb_version(): Release Version: v6.0.0
Edition: Community
Git Commit Hash: 36a9810441ca0e496cbd22064af274b3be771081
Git Branch: heads/refs/tags/v6.0.0
UTC Build Time: 2022-03-31 10:33:28
GoVersion: go1.18
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.0028 sec)

v5.4.1

sql> SELECT JSON_MERGE_PATCH('[1, 2]', '[true, false]') a, JSON_PRETTY('{}') b, (SELECT JSON_ARRAYAGG(x) FROM (SELECT 'a' x UNION ALL SELECT 'b') a) c, tidb_version()\G
*************************** 1. row ***************************
             a: [true, false]
             b: {}
             c: ["a", "b"]
tidb_version(): Release Version: v5.4.1
Edition: Community
Git Commit Hash: be484475e76b3aaa2cad520111353c3327db35fa
Git Branch: heads/refs/tags/v5.4.1
UTC Build Time: 2022-05-07 04:31:32
GoVersion: go1.16.4
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.0024 sec)

v5.3.1

sql> SELECT JSON_MERGE_PATCH('[1, 2]', '[true, false]') a, JSON_PRETTY('{}') b, (SELECT JSON_ARRAYAGG(x) FROM (SELECT 'a' x UNION ALL SELECT 'b') a) c, tidb_version()\G
*************************** 1. row ***************************
             a: [true, false]
             b: {}
             c: ["a", "b"]
tidb_version(): Release Version: v5.3.1
Edition: Community
Git Commit Hash: 459917c6f83df155edcc03f6ebde24942ff73b0e
Git Branch: heads/refs/tags/v5.3.1
UTC Build Time: 2022-03-02 08:35:22
GoVersion: go1.16.4
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.0022 sec)

v5.2.4

sql> SELECT JSON_MERGE_PATCH('[1, 2]', '[true, false]') a, JSON_PRETTY('{}') b, (SELECT JSON_ARRAYAGG(x) FROM (SELECT 'a' x UNION ALL SELECT 'b') a) c, tidb_version()\G
*************************** 1. row ***************************
             a: [true, false]
             b: {}
             c: ["a", "b"]
tidb_version(): Release Version: v5.2.4
Edition: Community
Git Commit Hash: fe5aa9760b587799361c954cffab4d786dbdbf7e
Git Branch: heads/refs/tags/v5.2.4
UTC Build Time: 2022-04-18 06:22:05
GoVersion: go1.16.4
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.0023 sec)

v5.1.3

sql> SELECT JSON_MERGE_PATCH('[1, 2]', '[true, false]') a, JSON_PRETTY('{}') b, (SELECT JSON_ARRAYAGG(x) FROM (SELECT 'a' x UNION ALL SELECT 'b') a) c, tidb_version()\G
ERROR: 1305 (42000): FUNCTION JSON_MERGE_PATCH does not exist

sql> SELECT JSON_PRETTY('{}') b, (SELECT JSON_ARRAYAGG(x) FROM (SELECT 'a' x UNION ALL SELECT 'b') a) c, tidb_version()\G
ERROR: 1105 (HY000): unsupported agg function: json_arrayagg

sql> SELECT JSON_PRETTY('{}') b, tidb_version()\G
*************************** 1. row ***************************
             b: {}
tidb_version(): Release Version: v5.1.3
Edition: Community
Git Commit Hash: dc079337ef0c9d78eec2d2acb1eb31e12117d29b
Git Branch: heads/refs/tags/v5.1.3
UTC Build Time: 2021-11-26 01:30:03
GoVersion: go1.16.4
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.0012 sec)

v5.0.6

sql> SELECT JSON_PRETTY('{}') b, tidb_version()\G
ERROR: 1305 (42000): FUNCTION JSON_PRETTY does not exist

sql> SELECT tidb_version()\G
*************************** 1. row ***************************
tidb_version(): Release Version: v5.0.6
Edition: Community
Git Commit Hash: 6416f8d601472892d245b950dfd5547e857a1a33
Git Branch: heads/refs/tags/v5.0.6
UTC Build Time: 2021-12-23 12:26:47
GoVersion: go1.13
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.0009 sec)

So:

  • 6.1, 5.4, 5.3 an 5.2 get the full backport
  • 5.1 needs to only have JSON_PRETTY()
  • 5.0 and older may need formatting fixes, but don't have the newer JSON functions

@ti-chi-bot
Copy link
Member

@dveeden: new pull request created: #9019.

In response to this:

/cherry-pick release-6.1
/cherry-pick release-5.4
/cherry-pick release-5.3
/cherry-pick release-5.2
/cherry-pick release-5.1

v6.1.0

sql> SELECT JSON_MERGE_PATCH('[1, 2]', '[true, false]') a, JSON_PRETTY('{}') b, (SELECT JSON_ARRAYAGG(x) FROM (SELECT 'a' x UNION ALL SELECT 'b') a) c, tidb_version()\G
*************************** 1. row ***************************
            a: [true, false]
            b: {}
            c: ["a", "b"]
tidb_version(): Release Version: v6.1.0
Edition: Community
Git Commit Hash: 1a89decdb192cbdce6a7b0020d71128bc964d30f
Git Branch: heads/refs/tags/v6.1.0
UTC Build Time: 2022-06-05 05:15:11
GoVersion: go1.18.2
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.0023 sec)

v6.0.0

sql> SELECT JSON_MERGE_PATCH('[1, 2]', '[true, false]') a, JSON_PRETTY('{}') b, (SELECT JSON_ARRAYAGG(x) FROM (SELECT 'a' x UNION ALL SELECT 'b') a) c, tidb_version()\G
*************************** 1. row ***************************
            a: [true, false]
            b: {}
            c: ["a", "b"]
tidb_version(): Release Version: v6.0.0
Edition: Community
Git Commit Hash: 36a9810441ca0e496cbd22064af274b3be771081
Git Branch: heads/refs/tags/v6.0.0
UTC Build Time: 2022-03-31 10:33:28
GoVersion: go1.18
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.0028 sec)

v5.4.1

sql> SELECT JSON_MERGE_PATCH('[1, 2]', '[true, false]') a, JSON_PRETTY('{}') b, (SELECT JSON_ARRAYAGG(x) FROM (SELECT 'a' x UNION ALL SELECT 'b') a) c, tidb_version()\G
*************************** 1. row ***************************
            a: [true, false]
            b: {}
            c: ["a", "b"]
tidb_version(): Release Version: v5.4.1
Edition: Community
Git Commit Hash: be484475e76b3aaa2cad520111353c3327db35fa
Git Branch: heads/refs/tags/v5.4.1
UTC Build Time: 2022-05-07 04:31:32
GoVersion: go1.16.4
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.0024 sec)

v5.3.1

sql> SELECT JSON_MERGE_PATCH('[1, 2]', '[true, false]') a, JSON_PRETTY('{}') b, (SELECT JSON_ARRAYAGG(x) FROM (SELECT 'a' x UNION ALL SELECT 'b') a) c, tidb_version()\G
*************************** 1. row ***************************
            a: [true, false]
            b: {}
            c: ["a", "b"]
tidb_version(): Release Version: v5.3.1
Edition: Community
Git Commit Hash: 459917c6f83df155edcc03f6ebde24942ff73b0e
Git Branch: heads/refs/tags/v5.3.1
UTC Build Time: 2022-03-02 08:35:22
GoVersion: go1.16.4
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.0022 sec)

v5.2.4

sql> SELECT JSON_MERGE_PATCH('[1, 2]', '[true, false]') a, JSON_PRETTY('{}') b, (SELECT JSON_ARRAYAGG(x) FROM (SELECT 'a' x UNION ALL SELECT 'b') a) c, tidb_version()\G
*************************** 1. row ***************************
            a: [true, false]
            b: {}
            c: ["a", "b"]
tidb_version(): Release Version: v5.2.4
Edition: Community
Git Commit Hash: fe5aa9760b587799361c954cffab4d786dbdbf7e
Git Branch: heads/refs/tags/v5.2.4
UTC Build Time: 2022-04-18 06:22:05
GoVersion: go1.16.4
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.0023 sec)

v5.1.3

sql> SELECT JSON_MERGE_PATCH('[1, 2]', '[true, false]') a, JSON_PRETTY('{}') b, (SELECT JSON_ARRAYAGG(x) FROM (SELECT 'a' x UNION ALL SELECT 'b') a) c, tidb_version()\G
ERROR: 1305 (42000): FUNCTION JSON_MERGE_PATCH does not exist

sql> SELECT JSON_PRETTY('{}') b, (SELECT JSON_ARRAYAGG(x) FROM (SELECT 'a' x UNION ALL SELECT 'b') a) c, tidb_version()\G
ERROR: 1105 (HY000): unsupported agg function: json_arrayagg

sql> SELECT JSON_PRETTY('{}') b, tidb_version()\G
*************************** 1. row ***************************
            b: {}
tidb_version(): Release Version: v5.1.3
Edition: Community
Git Commit Hash: dc079337ef0c9d78eec2d2acb1eb31e12117d29b
Git Branch: heads/refs/tags/v5.1.3
UTC Build Time: 2021-11-26 01:30:03
GoVersion: go1.16.4
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.0012 sec)

v5.0.6

sql> SELECT JSON_PRETTY('{}') b, tidb_version()\G
ERROR: 1305 (42000): FUNCTION JSON_PRETTY does not exist

sql> SELECT tidb_version()\G
*************************** 1. row ***************************
tidb_version(): Release Version: v5.0.6
Edition: Community
Git Commit Hash: 6416f8d601472892d245b950dfd5547e857a1a33
Git Branch: heads/refs/tags/v5.0.6
UTC Build Time: 2021-12-23 12:26:47
GoVersion: go1.13
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.0009 sec)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@dveeden: new pull request created: #9020.

In response to this:

/cherry-pick release-6.1
/cherry-pick release-5.4
/cherry-pick release-5.3
/cherry-pick release-5.2
/cherry-pick release-5.1

v6.1.0

sql> SELECT JSON_MERGE_PATCH('[1, 2]', '[true, false]') a, JSON_PRETTY('{}') b, (SELECT JSON_ARRAYAGG(x) FROM (SELECT 'a' x UNION ALL SELECT 'b') a) c, tidb_version()\G
*************************** 1. row ***************************
            a: [true, false]
            b: {}
            c: ["a", "b"]
tidb_version(): Release Version: v6.1.0
Edition: Community
Git Commit Hash: 1a89decdb192cbdce6a7b0020d71128bc964d30f
Git Branch: heads/refs/tags/v6.1.0
UTC Build Time: 2022-06-05 05:15:11
GoVersion: go1.18.2
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.0023 sec)

v6.0.0

sql> SELECT JSON_MERGE_PATCH('[1, 2]', '[true, false]') a, JSON_PRETTY('{}') b, (SELECT JSON_ARRAYAGG(x) FROM (SELECT 'a' x UNION ALL SELECT 'b') a) c, tidb_version()\G
*************************** 1. row ***************************
            a: [true, false]
            b: {}
            c: ["a", "b"]
tidb_version(): Release Version: v6.0.0
Edition: Community
Git Commit Hash: 36a9810441ca0e496cbd22064af274b3be771081
Git Branch: heads/refs/tags/v6.0.0
UTC Build Time: 2022-03-31 10:33:28
GoVersion: go1.18
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.0028 sec)

v5.4.1

sql> SELECT JSON_MERGE_PATCH('[1, 2]', '[true, false]') a, JSON_PRETTY('{}') b, (SELECT JSON_ARRAYAGG(x) FROM (SELECT 'a' x UNION ALL SELECT 'b') a) c, tidb_version()\G
*************************** 1. row ***************************
            a: [true, false]
            b: {}
            c: ["a", "b"]
tidb_version(): Release Version: v5.4.1
Edition: Community
Git Commit Hash: be484475e76b3aaa2cad520111353c3327db35fa
Git Branch: heads/refs/tags/v5.4.1
UTC Build Time: 2022-05-07 04:31:32
GoVersion: go1.16.4
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.0024 sec)

v5.3.1

sql> SELECT JSON_MERGE_PATCH('[1, 2]', '[true, false]') a, JSON_PRETTY('{}') b, (SELECT JSON_ARRAYAGG(x) FROM (SELECT 'a' x UNION ALL SELECT 'b') a) c, tidb_version()\G
*************************** 1. row ***************************
            a: [true, false]
            b: {}
            c: ["a", "b"]
tidb_version(): Release Version: v5.3.1
Edition: Community
Git Commit Hash: 459917c6f83df155edcc03f6ebde24942ff73b0e
Git Branch: heads/refs/tags/v5.3.1
UTC Build Time: 2022-03-02 08:35:22
GoVersion: go1.16.4
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.0022 sec)

v5.2.4

sql> SELECT JSON_MERGE_PATCH('[1, 2]', '[true, false]') a, JSON_PRETTY('{}') b, (SELECT JSON_ARRAYAGG(x) FROM (SELECT 'a' x UNION ALL SELECT 'b') a) c, tidb_version()\G
*************************** 1. row ***************************
            a: [true, false]
            b: {}
            c: ["a", "b"]
tidb_version(): Release Version: v5.2.4
Edition: Community
Git Commit Hash: fe5aa9760b587799361c954cffab4d786dbdbf7e
Git Branch: heads/refs/tags/v5.2.4
UTC Build Time: 2022-04-18 06:22:05
GoVersion: go1.16.4
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.0023 sec)

v5.1.3

sql> SELECT JSON_MERGE_PATCH('[1, 2]', '[true, false]') a, JSON_PRETTY('{}') b, (SELECT JSON_ARRAYAGG(x) FROM (SELECT 'a' x UNION ALL SELECT 'b') a) c, tidb_version()\G
ERROR: 1305 (42000): FUNCTION JSON_MERGE_PATCH does not exist

sql> SELECT JSON_PRETTY('{}') b, (SELECT JSON_ARRAYAGG(x) FROM (SELECT 'a' x UNION ALL SELECT 'b') a) c, tidb_version()\G
ERROR: 1105 (HY000): unsupported agg function: json_arrayagg

sql> SELECT JSON_PRETTY('{}') b, tidb_version()\G
*************************** 1. row ***************************
            b: {}
tidb_version(): Release Version: v5.1.3
Edition: Community
Git Commit Hash: dc079337ef0c9d78eec2d2acb1eb31e12117d29b
Git Branch: heads/refs/tags/v5.1.3
UTC Build Time: 2021-11-26 01:30:03
GoVersion: go1.16.4
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.0012 sec)

v5.0.6

sql> SELECT JSON_PRETTY('{}') b, tidb_version()\G
ERROR: 1305 (42000): FUNCTION JSON_PRETTY does not exist

sql> SELECT tidb_version()\G
*************************** 1. row ***************************
tidb_version(): Release Version: v5.0.6
Edition: Community
Git Commit Hash: 6416f8d601472892d245b950dfd5547e857a1a33
Git Branch: heads/refs/tags/v5.0.6
UTC Build Time: 2021-12-23 12:26:47
GoVersion: go1.13
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.0009 sec)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@dveeden: new pull request created: #9021.

In response to this:

/cherry-pick release-6.1
/cherry-pick release-5.4
/cherry-pick release-5.3
/cherry-pick release-5.2
/cherry-pick release-5.1

v6.1.0

sql> SELECT JSON_MERGE_PATCH('[1, 2]', '[true, false]') a, JSON_PRETTY('{}') b, (SELECT JSON_ARRAYAGG(x) FROM (SELECT 'a' x UNION ALL SELECT 'b') a) c, tidb_version()\G
*************************** 1. row ***************************
            a: [true, false]
            b: {}
            c: ["a", "b"]
tidb_version(): Release Version: v6.1.0
Edition: Community
Git Commit Hash: 1a89decdb192cbdce6a7b0020d71128bc964d30f
Git Branch: heads/refs/tags/v6.1.0
UTC Build Time: 2022-06-05 05:15:11
GoVersion: go1.18.2
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.0023 sec)

v6.0.0

sql> SELECT JSON_MERGE_PATCH('[1, 2]', '[true, false]') a, JSON_PRETTY('{}') b, (SELECT JSON_ARRAYAGG(x) FROM (SELECT 'a' x UNION ALL SELECT 'b') a) c, tidb_version()\G
*************************** 1. row ***************************
            a: [true, false]
            b: {}
            c: ["a", "b"]
tidb_version(): Release Version: v6.0.0
Edition: Community
Git Commit Hash: 36a9810441ca0e496cbd22064af274b3be771081
Git Branch: heads/refs/tags/v6.0.0
UTC Build Time: 2022-03-31 10:33:28
GoVersion: go1.18
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.0028 sec)

v5.4.1

sql> SELECT JSON_MERGE_PATCH('[1, 2]', '[true, false]') a, JSON_PRETTY('{}') b, (SELECT JSON_ARRAYAGG(x) FROM (SELECT 'a' x UNION ALL SELECT 'b') a) c, tidb_version()\G
*************************** 1. row ***************************
            a: [true, false]
            b: {}
            c: ["a", "b"]
tidb_version(): Release Version: v5.4.1
Edition: Community
Git Commit Hash: be484475e76b3aaa2cad520111353c3327db35fa
Git Branch: heads/refs/tags/v5.4.1
UTC Build Time: 2022-05-07 04:31:32
GoVersion: go1.16.4
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.0024 sec)

v5.3.1

sql> SELECT JSON_MERGE_PATCH('[1, 2]', '[true, false]') a, JSON_PRETTY('{}') b, (SELECT JSON_ARRAYAGG(x) FROM (SELECT 'a' x UNION ALL SELECT 'b') a) c, tidb_version()\G
*************************** 1. row ***************************
            a: [true, false]
            b: {}
            c: ["a", "b"]
tidb_version(): Release Version: v5.3.1
Edition: Community
Git Commit Hash: 459917c6f83df155edcc03f6ebde24942ff73b0e
Git Branch: heads/refs/tags/v5.3.1
UTC Build Time: 2022-03-02 08:35:22
GoVersion: go1.16.4
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.0022 sec)

v5.2.4

sql> SELECT JSON_MERGE_PATCH('[1, 2]', '[true, false]') a, JSON_PRETTY('{}') b, (SELECT JSON_ARRAYAGG(x) FROM (SELECT 'a' x UNION ALL SELECT 'b') a) c, tidb_version()\G
*************************** 1. row ***************************
            a: [true, false]
            b: {}
            c: ["a", "b"]
tidb_version(): Release Version: v5.2.4
Edition: Community
Git Commit Hash: fe5aa9760b587799361c954cffab4d786dbdbf7e
Git Branch: heads/refs/tags/v5.2.4
UTC Build Time: 2022-04-18 06:22:05
GoVersion: go1.16.4
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.0023 sec)

v5.1.3

sql> SELECT JSON_MERGE_PATCH('[1, 2]', '[true, false]') a, JSON_PRETTY('{}') b, (SELECT JSON_ARRAYAGG(x) FROM (SELECT 'a' x UNION ALL SELECT 'b') a) c, tidb_version()\G
ERROR: 1305 (42000): FUNCTION JSON_MERGE_PATCH does not exist

sql> SELECT JSON_PRETTY('{}') b, (SELECT JSON_ARRAYAGG(x) FROM (SELECT 'a' x UNION ALL SELECT 'b') a) c, tidb_version()\G
ERROR: 1105 (HY000): unsupported agg function: json_arrayagg

sql> SELECT JSON_PRETTY('{}') b, tidb_version()\G
*************************** 1. row ***************************
            b: {}
tidb_version(): Release Version: v5.1.3
Edition: Community
Git Commit Hash: dc079337ef0c9d78eec2d2acb1eb31e12117d29b
Git Branch: heads/refs/tags/v5.1.3
UTC Build Time: 2021-11-26 01:30:03
GoVersion: go1.16.4
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.0012 sec)

v5.0.6

sql> SELECT JSON_PRETTY('{}') b, tidb_version()\G
ERROR: 1305 (42000): FUNCTION JSON_PRETTY does not exist

sql> SELECT tidb_version()\G
*************************** 1. row ***************************
tidb_version(): Release Version: v5.0.6
Edition: Community
Git Commit Hash: 6416f8d601472892d245b950dfd5547e857a1a33
Git Branch: heads/refs/tags/v5.0.6
UTC Build Time: 2021-12-23 12:26:47
GoVersion: go1.13
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.0009 sec)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@dveeden: new pull request created: #9022.

In response to this:

/cherry-pick release-6.1
/cherry-pick release-5.4
/cherry-pick release-5.3
/cherry-pick release-5.2
/cherry-pick release-5.1

v6.1.0

sql> SELECT JSON_MERGE_PATCH('[1, 2]', '[true, false]') a, JSON_PRETTY('{}') b, (SELECT JSON_ARRAYAGG(x) FROM (SELECT 'a' x UNION ALL SELECT 'b') a) c, tidb_version()\G
*************************** 1. row ***************************
            a: [true, false]
            b: {}
            c: ["a", "b"]
tidb_version(): Release Version: v6.1.0
Edition: Community
Git Commit Hash: 1a89decdb192cbdce6a7b0020d71128bc964d30f
Git Branch: heads/refs/tags/v6.1.0
UTC Build Time: 2022-06-05 05:15:11
GoVersion: go1.18.2
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.0023 sec)

v6.0.0

sql> SELECT JSON_MERGE_PATCH('[1, 2]', '[true, false]') a, JSON_PRETTY('{}') b, (SELECT JSON_ARRAYAGG(x) FROM (SELECT 'a' x UNION ALL SELECT 'b') a) c, tidb_version()\G
*************************** 1. row ***************************
            a: [true, false]
            b: {}
            c: ["a", "b"]
tidb_version(): Release Version: v6.0.0
Edition: Community
Git Commit Hash: 36a9810441ca0e496cbd22064af274b3be771081
Git Branch: heads/refs/tags/v6.0.0
UTC Build Time: 2022-03-31 10:33:28
GoVersion: go1.18
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.0028 sec)

v5.4.1

sql> SELECT JSON_MERGE_PATCH('[1, 2]', '[true, false]') a, JSON_PRETTY('{}') b, (SELECT JSON_ARRAYAGG(x) FROM (SELECT 'a' x UNION ALL SELECT 'b') a) c, tidb_version()\G
*************************** 1. row ***************************
            a: [true, false]
            b: {}
            c: ["a", "b"]
tidb_version(): Release Version: v5.4.1
Edition: Community
Git Commit Hash: be484475e76b3aaa2cad520111353c3327db35fa
Git Branch: heads/refs/tags/v5.4.1
UTC Build Time: 2022-05-07 04:31:32
GoVersion: go1.16.4
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.0024 sec)

v5.3.1

sql> SELECT JSON_MERGE_PATCH('[1, 2]', '[true, false]') a, JSON_PRETTY('{}') b, (SELECT JSON_ARRAYAGG(x) FROM (SELECT 'a' x UNION ALL SELECT 'b') a) c, tidb_version()\G
*************************** 1. row ***************************
            a: [true, false]
            b: {}
            c: ["a", "b"]
tidb_version(): Release Version: v5.3.1
Edition: Community
Git Commit Hash: 459917c6f83df155edcc03f6ebde24942ff73b0e
Git Branch: heads/refs/tags/v5.3.1
UTC Build Time: 2022-03-02 08:35:22
GoVersion: go1.16.4
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.0022 sec)

v5.2.4

sql> SELECT JSON_MERGE_PATCH('[1, 2]', '[true, false]') a, JSON_PRETTY('{}') b, (SELECT JSON_ARRAYAGG(x) FROM (SELECT 'a' x UNION ALL SELECT 'b') a) c, tidb_version()\G
*************************** 1. row ***************************
            a: [true, false]
            b: {}
            c: ["a", "b"]
tidb_version(): Release Version: v5.2.4
Edition: Community
Git Commit Hash: fe5aa9760b587799361c954cffab4d786dbdbf7e
Git Branch: heads/refs/tags/v5.2.4
UTC Build Time: 2022-04-18 06:22:05
GoVersion: go1.16.4
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.0023 sec)

v5.1.3

sql> SELECT JSON_MERGE_PATCH('[1, 2]', '[true, false]') a, JSON_PRETTY('{}') b, (SELECT JSON_ARRAYAGG(x) FROM (SELECT 'a' x UNION ALL SELECT 'b') a) c, tidb_version()\G
ERROR: 1305 (42000): FUNCTION JSON_MERGE_PATCH does not exist

sql> SELECT JSON_PRETTY('{}') b, (SELECT JSON_ARRAYAGG(x) FROM (SELECT 'a' x UNION ALL SELECT 'b') a) c, tidb_version()\G
ERROR: 1105 (HY000): unsupported agg function: json_arrayagg

sql> SELECT JSON_PRETTY('{}') b, tidb_version()\G
*************************** 1. row ***************************
            b: {}
tidb_version(): Release Version: v5.1.3
Edition: Community
Git Commit Hash: dc079337ef0c9d78eec2d2acb1eb31e12117d29b
Git Branch: heads/refs/tags/v5.1.3
UTC Build Time: 2021-11-26 01:30:03
GoVersion: go1.16.4
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.0012 sec)

v5.0.6

sql> SELECT JSON_PRETTY('{}') b, tidb_version()\G
ERROR: 1305 (42000): FUNCTION JSON_PRETTY does not exist

sql> SELECT tidb_version()\G
*************************** 1. row ***************************
tidb_version(): Release Version: v5.0.6
Edition: Community
Git Commit Hash: 6416f8d601472892d245b950dfd5547e857a1a33
Git Branch: heads/refs/tags/v5.0.6
UTC Build Time: 2021-12-23 12:26:47
GoVersion: go1.13
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.0009 sec)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@dveeden: new pull request created: #9023.

In response to this:

/cherry-pick release-6.1
/cherry-pick release-5.4
/cherry-pick release-5.3
/cherry-pick release-5.2
/cherry-pick release-5.1

v6.1.0

sql> SELECT JSON_MERGE_PATCH('[1, 2]', '[true, false]') a, JSON_PRETTY('{}') b, (SELECT JSON_ARRAYAGG(x) FROM (SELECT 'a' x UNION ALL SELECT 'b') a) c, tidb_version()\G
*************************** 1. row ***************************
            a: [true, false]
            b: {}
            c: ["a", "b"]
tidb_version(): Release Version: v6.1.0
Edition: Community
Git Commit Hash: 1a89decdb192cbdce6a7b0020d71128bc964d30f
Git Branch: heads/refs/tags/v6.1.0
UTC Build Time: 2022-06-05 05:15:11
GoVersion: go1.18.2
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.0023 sec)

v6.0.0

sql> SELECT JSON_MERGE_PATCH('[1, 2]', '[true, false]') a, JSON_PRETTY('{}') b, (SELECT JSON_ARRAYAGG(x) FROM (SELECT 'a' x UNION ALL SELECT 'b') a) c, tidb_version()\G
*************************** 1. row ***************************
            a: [true, false]
            b: {}
            c: ["a", "b"]
tidb_version(): Release Version: v6.0.0
Edition: Community
Git Commit Hash: 36a9810441ca0e496cbd22064af274b3be771081
Git Branch: heads/refs/tags/v6.0.0
UTC Build Time: 2022-03-31 10:33:28
GoVersion: go1.18
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.0028 sec)

v5.4.1

sql> SELECT JSON_MERGE_PATCH('[1, 2]', '[true, false]') a, JSON_PRETTY('{}') b, (SELECT JSON_ARRAYAGG(x) FROM (SELECT 'a' x UNION ALL SELECT 'b') a) c, tidb_version()\G
*************************** 1. row ***************************
            a: [true, false]
            b: {}
            c: ["a", "b"]
tidb_version(): Release Version: v5.4.1
Edition: Community
Git Commit Hash: be484475e76b3aaa2cad520111353c3327db35fa
Git Branch: heads/refs/tags/v5.4.1
UTC Build Time: 2022-05-07 04:31:32
GoVersion: go1.16.4
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.0024 sec)

v5.3.1

sql> SELECT JSON_MERGE_PATCH('[1, 2]', '[true, false]') a, JSON_PRETTY('{}') b, (SELECT JSON_ARRAYAGG(x) FROM (SELECT 'a' x UNION ALL SELECT 'b') a) c, tidb_version()\G
*************************** 1. row ***************************
            a: [true, false]
            b: {}
            c: ["a", "b"]
tidb_version(): Release Version: v5.3.1
Edition: Community
Git Commit Hash: 459917c6f83df155edcc03f6ebde24942ff73b0e
Git Branch: heads/refs/tags/v5.3.1
UTC Build Time: 2022-03-02 08:35:22
GoVersion: go1.16.4
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.0022 sec)

v5.2.4

sql> SELECT JSON_MERGE_PATCH('[1, 2]', '[true, false]') a, JSON_PRETTY('{}') b, (SELECT JSON_ARRAYAGG(x) FROM (SELECT 'a' x UNION ALL SELECT 'b') a) c, tidb_version()\G
*************************** 1. row ***************************
            a: [true, false]
            b: {}
            c: ["a", "b"]
tidb_version(): Release Version: v5.2.4
Edition: Community
Git Commit Hash: fe5aa9760b587799361c954cffab4d786dbdbf7e
Git Branch: heads/refs/tags/v5.2.4
UTC Build Time: 2022-04-18 06:22:05
GoVersion: go1.16.4
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.0023 sec)

v5.1.3

sql> SELECT JSON_MERGE_PATCH('[1, 2]', '[true, false]') a, JSON_PRETTY('{}') b, (SELECT JSON_ARRAYAGG(x) FROM (SELECT 'a' x UNION ALL SELECT 'b') a) c, tidb_version()\G
ERROR: 1305 (42000): FUNCTION JSON_MERGE_PATCH does not exist

sql> SELECT JSON_PRETTY('{}') b, (SELECT JSON_ARRAYAGG(x) FROM (SELECT 'a' x UNION ALL SELECT 'b') a) c, tidb_version()\G
ERROR: 1105 (HY000): unsupported agg function: json_arrayagg

sql> SELECT JSON_PRETTY('{}') b, tidb_version()\G
*************************** 1. row ***************************
            b: {}
tidb_version(): Release Version: v5.1.3
Edition: Community
Git Commit Hash: dc079337ef0c9d78eec2d2acb1eb31e12117d29b
Git Branch: heads/refs/tags/v5.1.3
UTC Build Time: 2021-11-26 01:30:03
GoVersion: go1.16.4
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.0012 sec)

v5.0.6

sql> SELECT JSON_PRETTY('{}') b, tidb_version()\G
ERROR: 1305 (42000): FUNCTION JSON_PRETTY does not exist

sql> SELECT tidb_version()\G
*************************** 1. row ***************************
tidb_version(): Release Version: v5.0.6
Edition: Community
Git Commit Hash: 6416f8d601472892d245b950dfd5547e857a1a33
Git Branch: heads/refs/tags/v5.0.6
UTC Build Time: 2021-12-23 12:26:47
GoVersion: go1.13
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.0009 sec)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@dveeden
Copy link
Contributor Author

dveeden commented Jun 20, 2022

I tried a simple script to detect if there are more issues like this in other pages.

[dvaneeden@dve-carbon docs]$ git checkout upstream/release-5.0
...
[dvaneeden@dve-carbon docs]$ awk -f /tmp/links.awk functions-and-operators/json-functions.md
No target defined for "json_objectagg" Link defined as: | [JSON_OBJECTAGG(key, value)][json_objectagg] | Provides an aggregation of values for a given key. |
No target defined for "json_storage_size" Link defined as: | [JSON_STORAGE_SIZE(json_doc)][json_storage_size] | Returns an approximate size of bytes required to store the json value. As the size does not account for TiKV using compression, the output of this function is not strictly compatible with MySQL. |

However it doesn't look like other pages have the same issue and there are some false positives, so this is not something we can easily add to CI/CD.

/\[.*\]\[.*\]/ {
	a=substr($0,index($0, "][")+2);
	links[substr(a,1,index(a,"]")-1)] = $0
}
/^\[.*\]: / {
	targets[substr($0,2,index($0, "]")-2)] = $0
}

END {
	for (link in links) {
		if (targets[link] == "") {
			print "No target defined for \"" link "\"", "Link defined as: " links[link]
		}
	}
}

shichun-0415 pushed a commit that referenced this pull request Jun 20, 2022
* json-functions: Update status and links

* Fix dead anchor

Co-authored-by: Daniël van Eeden <[email protected]>
TomShawn pushed a commit that referenced this pull request Jun 20, 2022
* json-functions: Update status and links

* Fix dead anchor

Co-authored-by: Daniël van Eeden <[email protected]>
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Jun 24, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9360.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. ONCALL Relates to documentation oncall. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants