-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parser: fix tableAlias in DeleteStmt
#521
Conversation
Codecov Report
@@ Coverage Diff @@
## master #521 +/- ##
==========================================
- Coverage 80% 71.76% -8.24%
==========================================
Files 32 32
Lines 12696 7813 -4883
==========================================
- Hits 10157 5607 -4550
+ Misses 1935 1676 -259
+ Partials 604 530 -74
Continue to review full report at Codecov.
|
But currently |
@spongedu We intend to be eventually compatible with 8.0 (pingcap/tidb#7968), so if a missing 5.7 feature is deprecated or removed on 8.0 we won't support it (unless it is trivial). Example of such rejected feature requests: pingcap/tidb#3685, pingcap/tidb#4025, pingcap/tidb#10092. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
@crazycs520 PTAL :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@spongedu Please help resolve the conflicting files. |
@SunRunAway PTAL :) |
/run-all-tests |
What problem does this PR solve?
#189 tried to implement
Restore
forDeleteStmt
, but there's a little mistake: the.*
syntax should not be defined as part ofTableName
. It should be defined as an independent term and be used inDeleteStmt
only, as is defined in MySQL ParserThis pr seems fix #357 as well.
Check List
Tests
Code changes
N / A
Side effects
N / A
Related changes