upgrade grpc to 1.23 #756
Merged
upgrade grpc to 1.23 #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
|
/run-integration-tests tidb=release-3.0 tikv=release-3.0 pd=release-3.0 |
|
/run-integration-tests tidb=release-3.0 tikv=release-3.0 pd=release-3.0 |
|
/run-all-tests tidb=release-3.0 tikv=release-3.0 pd=release-3.0 |
|
Very Nice！LGTM |
|
/run-all-tests tidb=release-3.0 tikv=release-3.0 pd=release-3.0 |
july2993
added a commit
to july2993/tidb-binlog
that referenced
this pull request
Oct 21, 2019
IANTHEREAL
pushed a commit
that referenced
this pull request
Oct 21, 2019
july2993
added a commit
to july2993/tidb-binlog
that referenced
this pull request
Nov 12, 2019
* go.mod: upgrade grpc to 1.23 * Fix client blocks until it receives a SETTINGS frame from the server * grpc.WithDialer is deprecated: use WithContextDialer instead.
IANTHEREAL
pushed a commit
that referenced
this pull request
Nov 12, 2019
july2993
added a commit
to july2993/tidb-binlog
that referenced
this pull request
Feb 14, 2020
* go.mod: upgrade grpc to 1.23 * Fix client blocks until it receives a SETTINGS frame from the server * grpc.WithDialer is deprecated: use WithContextDialer instead.
july2993
added a commit
to july2993/tidb-binlog
that referenced
this pull request
Feb 14, 2020
* go.mod: upgrade grpc to 1.23 * Fix client blocks until it receives a SETTINGS frame from the server * grpc.WithDialer is deprecated: use WithContextDialer instead.
july2993
added a commit
to july2993/tidb-binlog
that referenced
this pull request
Feb 14, 2020
* go.mod: upgrade grpc to 1.23 * Fix client blocks until it receives a SETTINGS frame from the server * grpc.WithDialer is deprecated: use WithContextDialer instead.
july2993
added a commit
that referenced
this pull request
Feb 14, 2020
overvenus
reviewed
Feb 22, 2020
| @@ -376,7 +376,12 @@ func (s *Server) Start() error { | |||
| // sets a timeout for the read of matchers | |||
| m.SetReadTimeout(time.Second * 10) | |||
|
|
|||
| grpcL := m.Match(cmux.HTTP2HeaderField("content-type", "application/grpc")) | |||
| // grpcL := m.Match(cmux.HTTP2HeaderField("content-type", "application/grpc")) | |||
There was a problem hiding this comment.
I think we can and better just delete it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
After pingcap/tidb#12055 tidb upgrade grpc to 1.23, the client can't no longer connect to pump server.
What is changed and how it works?
upgrade to gRPC to 1.23 from 1.17.
change cmux how to match for gRPC, see:
soheilhy/cmux#64
https://github.com/soheilhy/cmux#limitations
this still compatible with the older version tidb(with gRPC client 1.17).
Check List
Tests
run with 1.23 and 1.17 gRPC client version tidb
Code changes
Side effects
Related changes