Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update etcd to 3.5.15 #1707

Merged
merged 3 commits into from
Aug 15, 2024
Merged

update etcd to 3.5.15 #1707

merged 3 commits into from
Aug 15, 2024

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Jul 25, 2024

It can be reviewed after #1709 merged

ref tikv/pd#3877

@CLAassistant
Copy link

CLAassistant commented Jul 25, 2024

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added the size/XL label Jul 25, 2024
@lhy1024 lhy1024 force-pushed the update-etcd-client branch from df3e304 to 1b40a3d Compare July 25, 2024 13:20
@ti-chi-bot ti-chi-bot bot added size/XXL and removed size/XL labels Jul 25, 2024
@lhy1024 lhy1024 force-pushed the update-etcd-client branch 4 times, most recently from 0137e3c to 6909d2a Compare July 30, 2024 09:22
@wuhuizuo
Copy link
Contributor

wuhuizuo commented Aug 1, 2024

will we request to upgrade the etcd server? I thinks the client version should keep same with the server version we recommend to deploy.

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Aug 1, 2024

will we request to upgrade the etcd server? I thinks the client version should keep same with the server version we recommend to deploy.

And the PD also need to upgrade etcd if it does. and the ectdctl binary in release artifacts.

@lhy1024
Copy link
Contributor Author

lhy1024 commented Aug 2, 2024

will we request to upgrade the etcd server? I thinks the client version should keep same with the server version we recommend to deploy.

Yes, I am trying for it tikv/pd#8441

Signed-off-by: lhy1024 <[email protected]>
lhy1024 added 2 commits August 7, 2024 18:28
Signed-off-by: lhy1024 <[email protected]>
Signed-off-by: lhy1024 <[email protected]>
@lhy1024 lhy1024 marked this pull request as ready for review August 7, 2024 11:04
@wuhuizuo
Copy link
Contributor

wuhuizuo commented Aug 8, 2024

/hold
it should merge to master after release-8.3 created.

@lhy1024
Copy link
Contributor Author

lhy1024 commented Aug 14, 2024

/unhold
https://github.com/tikv/pd/tree/release-8.3 has been created cc @wuhuizuo
PTAL @baurine @mornyx

@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 15, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 15, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-15 04:50:04.91312805 +0000 UTC m=+416289.616597692: ☑️ agreed by baurine.

Copy link
Contributor

ti-chi-bot bot commented Aug 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baurine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 15, 2024
@ti-chi-bot ti-chi-bot bot merged commit 4d89bc1 into pingcap:master Aug 15, 2024
8 checks passed
@lhy1024 lhy1024 deleted the update-etcd-client branch August 15, 2024 04:53
mornyx pushed a commit to ti-chi-bot/tidb-dashboard that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants