Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(validation): add toplogy validation by cel #6098

Merged
merged 3 commits into from
Feb 27, 2025

Conversation

liubog2008
Copy link
Member

  • add validation example with cel
  • add test pkg for validation

@ti-chi-bot ti-chi-bot bot requested a review from shonge February 27, 2025 05:04
@github-actions github-actions bot added the v2 for operator v2 label Feb 27, 2025
Copy link

/run-pull-e2e-kind-v2

@ti-chi-bot ti-chi-bot bot added the size/XXL label Feb 27, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.56%. Comparing base (ea7f455) to head (153f5e8).

Additional details and impacted files
@@             Coverage Diff             @@
##           feature/v2    #6098   +/-   ##
===========================================
  Coverage       54.56%   54.56%           
===========================================
  Files             224      224           
  Lines           15440    15440           
===========================================
  Hits             8425     8425           
  Misses           7015     7015           
Flag Coverage Δ
unittest 54.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: liubo02 <[email protected]>
Copy link

/run-pull-e2e-kind-v2

Signed-off-by: liubo02 <[email protected]>
Copy link

/run-pull-e2e-kind-v2

@fgksgf
Copy link
Member

fgksgf commented Feb 27, 2025

/lgtm

Copy link
Contributor

ti-chi-bot bot commented Feb 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fgksgf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 27, 2025
Copy link
Contributor

ti-chi-bot bot commented Feb 27, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-27 06:33:47.934656134 +0000 UTC m=+510375.887814401: ☑️ agreed by fgksgf.

@ti-chi-bot ti-chi-bot bot added the approved label Feb 27, 2025
@ti-chi-bot ti-chi-bot bot merged commit 11a522f into pingcap:feature/v2 Feb 27, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants