Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR#56093 may cause 8.8% performance regression in benchmarksql #56103

Closed
owlsome2501 opened this issue Sep 17, 2024 · 2 comments
Closed

PR#56093 may cause 8.8% performance regression in benchmarksql #56103

owlsome2501 opened this issue Sep 17, 2024 · 2 comments
Assignees
Labels
severity/critical sig/transaction SIG:Transaction type/bug The issue is confirmed as a bug. type/regression

Comments

@owlsome2501
Copy link

Bug Report

1. Minimal reproduce step (Required)

  1. Deploy a cluster with 3 TiDB and 3 Tikv.
  2. Run benchmark benchmarksql (benchmarksql-1k).

2. What did you expect to see? (Required)

No performance regression.

3. What did you see instead (Required)

#56093 caused QPS regression 8.83% in benchmark benchmarksql (benchmarksql-1k) compared to baseline 60193.12.

description tidb tikv pd QPS
last success a21d9ea tikv/tikv@7c61278 tikv/pd@098b802 57369.65
first regression 4c2ca6f tikv/tikv@7c61278 tikv/pd@098b802 54875.54

4. What is your TiDB version? (Required)

4c2ca6f

@MyonKeminta
Copy link
Contributor

The PR #56093 introduces tikv/pd#8483 to TiDB.

It's reasonable that this PR does have risk to introduce performance regression in non-current mode (which would be default after finishing tikv/pd#8432). However:

So I think this report looks quite doubtful.

But anyway, I prepared this PR as a fix to this problem: tikv/pd#8636

@MyonKeminta
Copy link
Contributor

Failed to reproduce the regression after 4 retries in total. Regard this as a misreport for now.

@MyonKeminta MyonKeminta closed this as not planned Won't fix, can't repro, duplicate, stale Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity/critical sig/transaction SIG:Transaction type/bug The issue is confirmed as a bug. type/regression
Projects
None yet
Development

No branches or pull requests

4 participants