Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storages: New serialization/deserialization for DataTypeString #9608

Merged
merged 20 commits into from
Dec 12, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update dbms/src/Storages/DeltaMerge/File/DMFileWriter.h
Co-authored-by: Lloyd-Pottiger <[email protected]>
JinheLin and Lloyd-Pottiger authored Dec 11, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 8a2353a724d1876e02f8ddd1cedfe94e8f7a51cd
2 changes: 1 addition & 1 deletion dbms/src/Storages/DeltaMerge/File/DMFileWriter.h
Original file line number Diff line number Diff line change
@@ -105,7 +105,7 @@ class DMFileWriter
const CompressionSetting & setting)
{
// Force use Lightweight compression for string sizes, since the string sizes almost always small.
// Performance of LZ4 to decompress such integers is not very well.
// Performance of LZ4 to decompress such integers is not good.
return isStringSizes(type, file_base_name)
? CompressionSetting{CompressionMethod::Lightweight, CompressionDataType::Int64}
: CompressionSetting::create<>(setting.method, setting.level, *type);