upgrade go to 1.23

pingcap · Sep 20, 2024 · 37d19fb · 37d19fb
1 parent 45c831a
commit 37d19fb
Show file tree

Hide file tree

Showing 25 changed files with 29 additions and 446 deletions.
diff --git a/.github/workflows/check_and_build.yaml b/.github/workflows/check_and_build.yaml
@@ -53,7 +53,7 @@ jobs:
       - name: Setup Go environment
         uses: actions/setup-go@v3
         with:
-          go-version: '1.21'
+          go-version: '1.23'
 
       - name: Cache Tools
         id: cache-tools
@@ -82,7 +82,7 @@ jobs:
       - name: Setup Go environment
         uses: actions/setup-go@v3
         with:
-          go-version: '1.21'
+          go-version: '1.23'
 
       - name: Build
         run: make build
diff --git a/.github/workflows/dataflow_engine_chaos.yaml b/.github/workflows/dataflow_engine_chaos.yaml
@@ -46,7 +46,7 @@ jobs:
 
       - uses: actions/setup-go@v3
         with:
-          go-version: '1.21'
+          go-version: '1.23'
 
       - name: Cache go modules
         uses: actions/cache@v2

diff --git a/.github/workflows/dm_binlog_999999.yaml b/.github/workflows/dm_binlog_999999.yaml
@@ -19,7 +19,7 @@ jobs:
       - name: Set up Go env
         uses: actions/setup-go@v3
         with:
-          go-version: '1.21'
+          go-version: '1.23'
 
       - name: Check out code
         uses: actions/checkout@v2

diff --git a/.github/workflows/dm_chaos.yaml b/.github/workflows/dm_chaos.yaml
@@ -40,7 +40,7 @@ jobs:
       - name: Set up Go env
         uses: actions/setup-go@v3
         with:
-          go-version: '1.21'
+          go-version: '1.23'
       - name: Print Go version
         run: go version
 

diff --git a/.github/workflows/dm_mariadb_master_down_and_up.yaml b/.github/workflows/dm_mariadb_master_down_and_up.yaml
@@ -17,7 +17,7 @@ jobs:
       - name: Set up Go env
         uses: actions/setup-go@v3
         with:
-          go-version: '1.21'
+          go-version: '1.23'
 
       - name: Check out code
         uses: actions/checkout@v2

diff --git a/.github/workflows/dm_upstream_switch.yaml b/.github/workflows/dm_upstream_switch.yaml
@@ -19,7 +19,7 @@ jobs:
       - name: Set up Go env
         uses: actions/setup-go@v3
         with:
-          go-version: '1.21'
+          go-version: '1.23'
 
       - name: Check out code
         uses: actions/checkout@v2

diff --git a/.github/workflows/upgrade_dm_via_tiup.yaml b/.github/workflows/upgrade_dm_via_tiup.yaml
@@ -35,7 +35,7 @@ jobs:
       - name: Set up Go env
         uses: actions/setup-go@v3
         with:
-          go-version: '1.21'
+          go-version: '1.23'
 
       - name: Check out code
         uses: actions/checkout@v2
@@ -86,7 +86,7 @@ jobs:
       - name: Set up Go env
         uses: actions/setup-go@v3
         with:
-          go-version: '1.21'
+          go-version: '1.23'
 
       - name: Check out code
         uses: actions/checkout@v2
@@ -193,7 +193,7 @@ jobs:
       - name: Set up Go env
         uses: actions/setup-go@v3
         with:
-          go-version: '1.21'
+          go-version: '1.23'
 
       - name: Check out code
         uses: actions/checkout@v2

diff --git a/.golangci.yml b/.golangci.yml
@@ -1,5 +1,5 @@
 run:
-  go: "1.21"
+  go: "1.23"
   build-tags:
     - intest
 linters:

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -14,7 +14,7 @@ your contribution accepted.
 
 Developing TiDB-CDC requires:
 
-* [Go 1.21+](https://go.dev/doc/code)
+* [Go 1.23+](https://go.dev/doc/code)
 * An internet connection to download the dependencies
 
 Simply run `make` to build the program.

diff --git a/README_DM.md b/README_DM.md
@@ -19,7 +19,7 @@ To check the code style and build binaries, you can simply run:
 make build
 ```
 
-Note that DM supports building with the Go version `Go >= 1.21`. For unit test preparation, see [Running/Unit Test](dm/tests/README.md#Unit-Test).
+Note that DM supports building with the Go version `Go >= 1.23`. For unit test preparation, see [Running/Unit Test](dm/tests/README.md#Unit-Test).
 
 If you only want to build binaries, you can run:
 

diff --git a/README_TiCDC.md b/README_TiCDC.md
@@ -27,7 +27,7 @@ $ make cdc
 $ make test
 ```
 
-Note that TiCDC supports building with the Go version `Go >= 1.21`.
+Note that TiCDC supports building with the Go version `Go >= 1.23`.
 
 When TiCDC is built successfully, you can find binary in the `bin` directory. Instructions for unit test and integration test can be found in [Running tests](./tests/integration_tests/README.md).
 

diff --git a/deployments/engine/docker/Dockerfile b/deployments/engine/docker/Dockerfile
@@ -1,4 +1,4 @@
-FROM golang:1.21-alpine as builder
+FROM golang:1.23-alpine as builder
 
 #build
 RUN apk add --no-cache \

diff --git a/deployments/engine/docker/dind.Dockerfile b/deployments/engine/docker/dind.Dockerfile
@@ -1,6 +1,6 @@
 # In this file, we build an image with `docker-cli in docker` for engine integration tests.
 # For `dockerd in docker`, please refer to https://hub.docker.com/_/docker/tags?page=1&name=dind.
-FROM golang:1.21-alpine as builder
+FROM golang:1.23-alpine as builder
 
 # If you add a new command dependency to engine integration test, add here and 
 # rebuild this image as well

diff --git a/deployments/ticdc/docker/Dockerfile b/deployments/ticdc/docker/Dockerfile
@@ -1,4 +1,4 @@
-FROM golang:1.21-alpine as builder
+FROM golang:1.23-alpine as builder
 RUN apk add --no-cache git make bash
 WORKDIR /go/src/github.com/pingcap/tiflow
 COPY . .

diff --git a/deployments/ticdc/docker/dev.Dockerfile b/deployments/ticdc/docker/dev.Dockerfile
@@ -1,4 +1,4 @@
-FROM golang:1.21-alpine as builder
+FROM golang:1.23-alpine as builder
 RUN apk add --no-cache git make bash findutils
 WORKDIR /go/src/github.com/pingcap/tiflow
 COPY . .

diff --git a/deployments/ticdc/docker/integration-test.Dockerfile b/deployments/ticdc/docker/integration-test.Dockerfile
@@ -29,7 +29,7 @@ RUN ./download-integration-test-binaries.sh $BRANCH $COMMUNITY $VERSION $OS $ARC
 RUN ls ./bin
 
 # Download go into /usr/local dir.
-ENV GOLANG_VERSION 1.21.0
+ENV GOLANG_VERSION 1.23.0
 ENV GOLANG_DOWNLOAD_URL https://dl.google.com/go/go$GOLANG_VERSION.linux-amd64.tar.gz
 RUN curl -fsSL "$GOLANG_DOWNLOAD_URL" -o golang.tar.gz \
 	&& tar -C /usr/local -xzf golang.tar.gz \

diff --git a/deployments/ticdc/docker/kafka-consumer.Dockerfile b/deployments/ticdc/docker/kafka-consumer.Dockerfile
@@ -1,4 +1,4 @@
-FROM golang:1.21-alpine as builder
+FROM golang:1.23-alpine as builder
 RUN apk add --no-cache make bash git build-base
 WORKDIR /go/src/github.com/pingcap/tiflow
 COPY . .

diff --git a/deployments/ticdc/docker/pulsar-integration-test.Dockerfile b/deployments/ticdc/docker/pulsar-integration-test.Dockerfile
@@ -1,6 +1,6 @@
 FROM openjdk:17 as jdk_container
 
-FROM hub.pingcap.net/jenkins/centos7_golang-1.21:latest
+FROM hub.pingcap.net/jenkins/centos7_golang-1.23:latest
 RUN curl https://archive.apache.org/dist/pulsar/pulsar-3.2.0/apache-pulsar-3.2.0-bin.tar.gz -o pulsar.tar.gz && \
     tar -xvf pulsar.tar.gz && \
     mv apache-pulsar-3.2.0 pulsar && \

diff --git a/deployments/ticdc/docker/storage-consumer.Dockerfile b/deployments/ticdc/docker/storage-consumer.Dockerfile
@@ -1,4 +1,4 @@
-FROM golang:1.21-alpine as builder
+FROM golang:1.23-alpine as builder
 RUN apk add --no-cache make bash git
 WORKDIR /go/src/github.com/pingcap/tiflow
 COPY . .

diff --git a/dm/Dockerfile b/dm/Dockerfile
@@ -1,4 +1,4 @@
-FROM golang:1.21-alpine as builder
+FROM golang:1.23-alpine as builder
 MAINTAINER siddontang
 
 RUN apk add --no-cache git make

diff --git a/examples/golang/avro-checksum-verification/go.mod b/examples/golang/avro-checksum-verification/go.mod
@@ -1,7 +1,6 @@
 module avro-checksum-sample
 
-go 1.21
-
+go 1.23
 require (
 	github.com/linkedin/goavro/v2 v2.11.1
 	github.com/pingcap/log v1.1.1-0.20230317032135-a0d097d16e22

diff --git a/examples/golang/canal-json-handle-key-only/go.mod b/examples/golang/canal-json-handle-key-only/go.mod
@@ -1,6 +1,6 @@
 module canal-json-handle-key-only-example
 
-go 1.21
+go 1.23
 
 require (
 	github.com/go-sql-driver/mysql v1.7.1