Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kafka(ticdc): fix kafka consumer doesn't check partition and old message #11483

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

wk989898
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #11482

What is changed and how it works?

Add partition check and old message check about simple protocol

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed contribution This PR is from a community contributor. labels Aug 13, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 13, 2024

Hi @wk989898. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 13, 2024
@3AceShowHand
Copy link
Contributor

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Sep 2, 2024
@3AceShowHand
Copy link
Contributor

/retest

@3AceShowHand
Copy link
Contributor

/check-issue-triage-complete

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.8732%. Comparing base (1e3766e) to head (ecfcb00).
Report is 54 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 62.0692% <ø> (+0.8667%) ⬆️
dm 51.2395% <ø> (+0.1939%) ⬆️
engine 53.4895% <ø> (-9.8843%) ⬇️
Flag Coverage Δ
unit 56.8732% <ø> (-0.5880%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11483        +/-   ##
================================================
- Coverage   57.4612%   56.8732%   -0.5880%     
================================================
  Files           850       1001       +151     
  Lines        126407     140697     +14290     
================================================
+ Hits          72635      80019      +7384     
- Misses        48364      54986      +6622     
- Partials       5408       5692       +284     

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 2, 2024
@wk989898
Copy link
Collaborator Author

wk989898 commented Sep 5, 2024

/retest

Copy link
Contributor

ti-chi-bot bot commented Oct 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, asddongmen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,asddongmen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 31, 2024
Copy link
Contributor

ti-chi-bot bot commented Oct 31, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-02 10:46:50.207460661 +0000 UTC m=+268534.725513582: ☑️ agreed by 3AceShowHand.
  • 2024-10-31 02:59:58.373875274 +0000 UTC m=+491511.213030820: ☑️ agreed by asddongmen.

@wk989898
Copy link
Collaborator Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 0510cf0 into pingcap:master Oct 31, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved contribution This PR is from a community contributor. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kafka consumer needs to correctly check partition and old message
3 participants