Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mounter(ticdc): reuse buf to reduce memory allocation when checksum enabled #11522

Closed
wants to merge 22 commits into from
Closed

mounter(ticdc): reuse buf to reduce memory allocation when checksum enabled #11522

wants to merge 22 commits into from

Conversation

3AceShowHand
Copy link
Contributor

@3AceShowHand 3AceShowHand commented Aug 27, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #11529

What is changed and how it works?

  • add one new struct to manage checksum calculation and verification related logic

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`None`

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 27, 2024
@3AceShowHand 3AceShowHand changed the title mounter(ticdc): reuse buf to reduce memory allocation when checksum enabled [DNM]mounter(ticdc): reuse buf to reduce memory allocation when checksum enabled Aug 27, 2024
@3AceShowHand 3AceShowHand changed the title [DNM]mounter(ticdc): reuse buf to reduce memory allocation when checksum enabled mounter(ticdc): reuse buf to reduce memory allocation when checksum enabled Aug 27, 2024
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 27, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 27, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 61.90476% with 32 lines in your changes missing coverage. Please review.

Project coverage is 57.5017%. Comparing base (434eda4) to head (603c321).
Report is 1 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 61.2781% <61.9047%> (+0.0488%) ⬆️
dm 51.0455% <ø> (ø)
engine 63.3738% <ø> (-0.0283%) ⬇️
Flag Coverage Δ
unit 57.5017% <61.9047%> (+0.0209%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11522        +/-   ##
================================================
+ Coverage   57.4807%   57.5017%   +0.0209%     
================================================
  Files           851        851                
  Lines        126524     126518         -6     
================================================
+ Hits          72727      72750        +23     
+ Misses        48399      48372        -27     
+ Partials       5398       5396         -2

@3AceShowHand
Copy link
Contributor Author

/retest

2 similar comments
@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

4 similar comments
@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

2 similar comments
@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

5 similar comments
@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

4 similar comments
@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 11, 2024

@3AceShowHand: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cdc-integration-mysql-test 603c321 link true /test cdc-integration-mysql-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@3AceShowHand
Copy link
Contributor Author

close this since does not see obvious throughput performance improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdojjy sdojjy sdojjy approved these changes

@asddongmen asddongmen asddongmen approved these changes

@CharlesCheung96 CharlesCheung96 CharlesCheung96 approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

introduce checksum verifier to manage checksum related functionality
4 participants
@3AceShowHand @sdojjy @asddongmen @CharlesCheung96