Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ticdc): fix data inconsistence on integration_tests #11584

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

wk989898
Copy link
Collaborator

@wk989898 wk989898 commented Sep 10, 2024

What problem does this PR solve?

Issue Number: close #11583

What is changed and how it works?

remove rows before add column xxx default now();

Check List

Tests

  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. contribution This PR is from a community contributor. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Sep 10, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 10, 2024

Hi @wk989898. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 10, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 10, 2024
@3AceShowHand
Copy link
Contributor

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 10, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 10, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-10 07:03:04.907940111 +0000 UTC m=+339854.648364050: ☑️ agreed by 3AceShowHand.
  • 2024-09-10 09:07:54.605408117 +0000 UTC m=+347344.345832073: ☑️ agreed by asddongmen.

Copy link
Contributor

ti-chi-bot bot commented Sep 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, asddongmen, CharlesCheung96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,CharlesCheung96,asddongmen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@CharlesCheung96
Copy link
Contributor

/retest

1 similar comment
@3AceShowHand
Copy link
Contributor

/retest

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.4728%. Comparing base (50659c4) to head (9d6fc3a).
Report is 9 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 61.2308% <ø> (+0.0357%) ⬆️
dm 51.0112% <ø> (-0.0122%) ⬇️
engine 63.4444% <ø> (+0.0635%) ⬆️
Flag Coverage Δ
unit 57.4728% <ø> (+0.0210%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11584        +/-   ##
================================================
+ Coverage   57.4518%   57.4728%   +0.0210%     
================================================
  Files           851        851                
  Lines        126492     126524        +32     
================================================
+ Hits          72672      72717        +45     
+ Misses        48408      48406         -2     
+ Partials       5412       5401        -11     

@ti-chi-bot ti-chi-bot bot merged commit c826978 into pingcap:master Sep 11, 2024
28 checks passed
wk989898 added a commit to wk989898/tiflow that referenced this pull request Sep 11, 2024
@wk989898 wk989898 deleted the integration-test branch September 12, 2024 15:53
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. labels Sep 20, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Sep 20, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #11608.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #11609.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Sep 20, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Sep 20, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #11610.

@ti-chi-bot ti-chi-bot bot removed the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Sep 20, 2024
wk989898 added a commit to wk989898/tiflow that referenced this pull request Sep 24, 2024
@ti-chi-bot ti-chi-bot bot removed needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. labels Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved contribution This PR is from a community contributor. lgtm needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

integration_tests with kafka_simple_basic arise data inconsistence
5 participants