Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dm: fix leader did not retire after delete the key #11604

Merged
merged 5 commits into from
Sep 24, 2024

Conversation

GMHDBJD
Copy link
Contributor

@GMHDBJD GMHDBJD commented Sep 18, 2024

What problem does this PR solve?

Issue Number: close #11602

What is changed and how it works?

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Fix leader did not retire after delete the key

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-triage-completed area/dm Issues or PRs related to DM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed labels Sep 18, 2024
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.6171%. Comparing base (45c831a) to head (88d0d0c).
Report is 3 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 61.4435% <ø> (+0.2113%) ⬆️
dm 51.0846% <100.0000%> (+0.0512%) ⬆️
engine 63.4444% <ø> (+0.0494%) ⬆️
Flag Coverage Δ
unit 57.6171% <100.0000%> (+0.1399%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11604        +/-   ##
================================================
+ Coverage   57.4771%   57.6171%   +0.1399%     
================================================
  Files           851        851                
  Lines        126539     126872       +333     
================================================
+ Hits          72731      73100       +369     
+ Misses        48407      48373        -34     
+ Partials       5401       5399         -2     

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why change filemode?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, I changed it back

dm/pkg/election/election_test.go Outdated Show resolved Hide resolved
dm/pkg/election/election_test.go Outdated Show resolved Hide resolved
dm/pkg/election/election_test.go Outdated Show resolved Hide resolved
dm/pkg/election/election_test.go Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 24, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 24, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 24, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-24 07:51:48.86383256 +0000 UTC m=+1552378.604256499: ☑️ agreed by lance6716.
  • 2024-09-24 07:56:50.178334364 +0000 UTC m=+1552679.918758303: ☑️ agreed by D3Hunter.

@ti-chi-bot ti-chi-bot bot merged commit d3aef11 into pingcap:master Sep 24, 2024
28 checks passed
@Benjamin2037 Benjamin2037 added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Sep 24, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #11625.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #11626.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dm Issues or PRs related to DM. lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple dm-master become leader at the same time
5 participants